Date: Tue, 5 Jul 2022 13:13:51 +0700 From: Eugene Grosbein <eugen@grosbein.net> To: Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: d80d73493767 - main - arp(8): use getifaddrs(3) instead of ioctl(SIOCGIFCONF) Message-ID: <d8f2a68c-b60d-1165-24e5-a2534fd64709@grosbein.net> In-Reply-To: <202207050356.2653uwfF062758@gitrepo.freebsd.org> References: <202207050356.2653uwfF062758@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
05.07.2022 10:56, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d80d73493767111b7569e831a93061014c682274 > > commit d80d73493767111b7569e831a93061014c682274 > Author: KUROSAWA Takahiro <takahiro.kurosawa@gmail.com> > AuthorDate: 2022-07-05 03:56:29 +0000 > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > CommitDate: 2022-07-05 03:56:29 +0000 > > arp(8): use getifaddrs(3) instead of ioctl(SIOCGIFCONF) > > The original code had used a fixed-size buffer for ioctl(SIOCGIFCONF), > that might cause the target ifreq spilled from the buffer. Use the handy > getifaddrs(3) to fix the problem. > > Reviewed by: glebius > Differential revision: https://reviews.freebsd.org/D35536 I have some production systems that suffered from this problem in the past. I used local dirty hacks to work-around the problem. Thank you very much for the fix. Please consider merge to stable branches.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d8f2a68c-b60d-1165-24e5-a2534fd64709>