From owner-svn-src-head@FreeBSD.ORG Thu Sep 2 10:41:05 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E2E01065709; Thu, 2 Sep 2010 10:41:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 3D6BE8FC1B; Thu, 2 Sep 2010 10:41:05 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id DE6AA46B2C; Thu, 2 Sep 2010 06:41:04 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8358A8A03C; Thu, 2 Sep 2010 06:40:52 -0400 (EDT) From: John Baldwin To: Kostik Belousov Date: Thu, 2 Sep 2010 06:39:46 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009010218.o812IX5G048257@svn.freebsd.org> <4C7FE06B.9070609@freebsd.org> <20100902102218.GO2396@deviant.kiev.zoral.com.ua> In-Reply-To: <20100902102218.GO2396@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201009020639.47198.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 02 Sep 2010 06:40:52 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, David Xu Subject: Re: svn commit: r212076 - head/lib/libthr/thread X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2010 10:41:05 -0000 On Thursday, September 02, 2010 6:22:18 am Kostik Belousov wrote: > On Thu, Sep 02, 2010 at 05:35:39PM +0000, David Xu wrote: > > Kostik Belousov wrote: > > > > >>the tf_err may not be equal to ksi_addr! This may need to be fixed. > > >> > > >The change was introduced by > > >r151316 | davidxu | 2005-10-14 > > > /* Old FreeBSD-style arguments. */ > > >- sf.sf_siginfo = code; > > >- sf.sf_addr = regs->tf_err; > > >+ sf.sf_siginfo = ksi->ksi_code; > > >+ sf.sf_addr = (register_t)ksi->ksi_addr; > > > sf.sf_ahu.sf_handler = catcher; > > > > > :( > The rollback looks straightforward. I explicitely decided to not change > any architecture that is not i386. It may not be this simple. At one point we had a "feature" where we trashed tf_err in the trapframe to store the address so it could be passed to sendsig for this purpose. I think once we started using ksi_addr here we removed the trashing of tf_err as it was no longer necessary. -- John Baldwin