From nobody Fri Feb 28 02:50:05 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z3t3f2kcPz5Mt4Y; Fri, 28 Feb 2025 02:50:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z3t3f0SCZz3LBF; Fri, 28 Feb 2025 02:50:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740711006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uIv/vPhJtPbkqWXBVBpP8a2kJP2pHoYx1RCm7PQhQlw=; b=aeE5b7BftO+g7Q22Ru6B3TrE7y6gJiqEXHVhK6QmuSCRJ7a0wQegI8We9fBztPL+1Jtk66 w7CMa2FPLhDd1D3MzCMeGUTDXERgP9oKCiV045a0ypb7F+BW6m/PAV9oFn7cnxUc+M35fF NILi1QbEKLDs+eukYVHj3/ffUaUb18ZtUv5yFu2rHnMJGDh6ptnQAYuy8/fxjXEmWEhLYk QQqraUYB/FagwEZeMz43DDV4pG6JhK1kEHNSqPAf+t5o5VgdZYW0kUVyvb6FQv3T3qrcQ+ fokkF4ZkIzPLiJ4KWaREcItk4qj3F6lPH8hptquIGyDpvvEtjsL3HuqMAjD2Cw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740711006; a=rsa-sha256; cv=none; b=G6c8kdOrJuvbkdfpoR4mix6s+8oOG23QTj4lhdDkLFVozEPmVJ9q7edTfhDAYaKEvCr3om bMSPU4eyBuP1Ge4qxHanJeDGSkf6tqFhuwdV5/KIjSV+Hw1jouMBLgzUNoDp6no3eUbN79 G598k7+bw3sNmYB/sz/yC7l1G4oDpwMbLIzG1jRfC5nmRMSYj5MjaU6DP5nU4oIM5oYwiA saEZL3tZDyNMrwK1FAdOxlzfmhKDgFFmska4hPid7SxeSQ1ukSW/c/QXpJU1Jsvd6tzxMj 5uy+SPAKdFfNZ7+7jwVxdoGeAggGYKD4UX1jGoKSXEdPeO8pyms0L8SEeR1a3Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740711006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uIv/vPhJtPbkqWXBVBpP8a2kJP2pHoYx1RCm7PQhQlw=; b=YUA8T6qLRpgs8csoDjEBnJrlKDyrNRI2uvsW5L8Yq39gFGJafR5ekBdp7f9Zz8qSzcO6qx vMHK9VwS5Dgij7bRg17GFLHmlqL31G97r4nhZJc9gHTYpNPXz1h47IK1AiEm98NKY95bMl 4hdBwqVCXUbtn+0kU7rajgX2Hl0bkPvp8hhpxH4sOHnAX3K5UyVAfbLEzSicK767Rwfrs+ 736AxlqePVZmMy16Hh8+8OqgCRgOUfuEXEGpaSv9sQxDMybhRZAtVY1DfkQhkznSMpy7ub LtQOn1w+Ex5+FlPNFxbZJ0ylLmxCxQObfZ2nxUr81ZbkIezpMVL7Lc3Ub0qomw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z3t3f03Xkz181d; Fri, 28 Feb 2025 02:50:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51S2o53C024193; Fri, 28 Feb 2025 02:50:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51S2o5fR024189; Fri, 28 Feb 2025 02:50:05 GMT (envelope-from git) Date: Fri, 28 Feb 2025 02:50:05 GMT Message-Id: <202502280250.51S2o5fR024189@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: 36347cfbf7ac - main - wlanwds: convert getifaddrs() iteration to use the ifa_next pointer List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 36347cfbf7ac3d1db79fa369266b1cc391daf511 Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=36347cfbf7ac3d1db79fa369266b1cc391daf511 commit 36347cfbf7ac3d1db79fa369266b1cc391daf511 Author: Adrian Chadd AuthorDate: 2025-02-27 02:18:23 +0000 Commit: Adrian Chadd CommitDate: 2025-02-28 02:49:49 +0000 wlanwds: convert getifaddrs() iteration to use the ifa_next pointer I don't know what I was thinking in 2017 when I wrote this, but it's very wrong. Use ifa->ifa_next to iterate, not the array index / pointer arithmetic. Differential Revision: https://reviews.freebsd.org/D49148 --- tools/tools/net80211/wlanwds/wlanwds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tools/net80211/wlanwds/wlanwds.c b/tools/tools/net80211/wlanwds/wlanwds.c index a9ca89e4d5b1..193a9b0a60d4 100644 --- a/tools/tools/net80211/wlanwds/wlanwds.c +++ b/tools/tools/net80211/wlanwds/wlanwds.c @@ -283,7 +283,7 @@ getlladdr(const char *ifname, uint8_t macaddr[ETHER_ADDR_LEN]) } /* Look for a matching interface */ - for (ifa = ifap; ifa != NULL; ifa++) { + for (ifa = ifap; ifa != NULL; ifa = ifa->ifa_next) { if (strcmp(ifname, ifa->ifa_name) != 0) continue;