From owner-svn-src-head@freebsd.org  Thu Jun 27 03:01:59 2019
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C785215D8DA4;
 Thu, 27 Jun 2019 03:01:59 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 35FBC6B57A;
 Thu, 27 Jun 2019 03:01:59 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x5R31srq057764;
 Wed, 26 Jun 2019 20:01:54 -0700 (PDT)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x5R31sLH057763;
 Wed, 26 Jun 2019 20:01:54 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <201906270301.x5R31sLH057763@gndrsh.dnsmgr.net>
Subject: Re: svn commit: r349450 - head/contrib/ipfilter/tools
In-Reply-To: <201906270243.x5R2hUZx070792@repo.freebsd.org>
To: Cy Schubert <cy@freebsd.org>
Date: Wed, 26 Jun 2019 20:01:54 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 35FBC6B57A
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.94 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.94)[-0.944,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jun 2019 03:02:00 -0000

> Author: cy
> Date: Thu Jun 27 02:43:30 2019
> New Revision: 349450
> URL: https://svnweb.freebsd.org/changeset/base/349450
> 
> Log:
>   Update usage() to refect the current state of ipmon.
>   
>   PR:		238816
>   MFC after:	1 week
> 
> Modified:
>   head/contrib/ipfilter/tools/ipmon.c
> 
> Modified: head/contrib/ipfilter/tools/ipmon.c
> ==============================================================================
> --- head/contrib/ipfilter/tools/ipmon.c	Thu Jun 27 02:43:26 2019	(r349449)
> +++ head/contrib/ipfilter/tools/ipmon.c	Thu Jun 27 02:43:30 2019	(r349450)
> @@ -1438,8 +1438,11 @@ printipflog:
>  static void usage(prog)
>  	char *prog;
>  {
> -	fprintf(stderr, "%s: [-NFhstvxX] [-f <logfile>]\n", prog);
> -	exit(1);
expected

> +	fprintf(stderr, "Usage: %s [ -abDFhnpstvxX ] [ -B <binary-logfile> ] [ -C <config-file> ]\n"
> +		"\t[ -f <device> ] [ -L <facility> ] [ -N <device> ]\n"
> +		"\t[ -o [NSI] ] [ -O [NSI] ] [ -P <pidfile> ] [ -S <device> ]\n"
> +		"\t[ <filename> ]\n", prog);
> +	exit(-1);

Was it intentional to flip the exit code to -1?
Someones scripts might not be prepared for that.

>  }

-- 
Rod Grimes                                                 rgrimes@freebsd.org