From owner-freebsd-bugs@FreeBSD.ORG  Tue Jan  6 19:16:29 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3799D1065670;
	Tue,  6 Jan 2009 19:16:29 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe08.swip.net [212.247.154.225])
	by mx1.freebsd.org (Postfix) with ESMTP id 67C098FC1A;
	Tue,  6 Jan 2009 19:16:28 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=6nre6YQGT9EA:10 a=4zEhLDbpA8gA:10
	a=rREUrScshOl7G2h6aTFPgw==:17 a=6I5d2MoRAAAA:8
	a=MAk8hmUIQ8iswzZ9XpUA:9 a=eNvjG_LKXEiJRd7lkGIA:7
	a=qOjMrAo3QR3x6paXwQOEmSiFf8MA:4 a=9aOQ2cSd83gA:10
	a=SV7veod9ZcQA:10 a=LY0hPdMaydYA:10
Received: from [62.73.248.227] (account mc467741@c2i.net [62.73.248.227]
	verified) by mailfe08.swip.net (CommuniGate Pro SMTP 5.2.6)
	with ESMTPA id 1174336176; Tue, 06 Jan 2009 20:16:26 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: "Garrett Cooper" <yanefbsd@gmail.com>
Date: Tue, 6 Jan 2009 20:18:48 +0100
User-Agent: KMail/1.9.7
References: <200812311256.mBVCuLT9096976@freefall.freebsd.org>
	<200901061932.54448.hselasky@c2i.net>
	<7d6fde3d0901061110r79333a07jf4eb134224a94747@mail.gmail.com>
In-Reply-To: <7d6fde3d0901061110r79333a07jf4eb134224a94747@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901062018.49338.hselasky@c2i.net>
Cc: Volker <volker@vwsoft.com>, Bruce Cran <bruce@cran.org.uk>,
	freebsd-bugs@freebsd.org, freebsd-usb@freebsd.org
Subject: Re: bin/129963: [newusb] usbconfig(8) fails with misleading error
	when run as a normal user
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jan 2009 19:16:29 -0000

On Tuesday 06 January 2009, Garrett Cooper wrote:
> On Tue, Jan 6, 2009 at 10:32 AM, Hans Petter Selasky <hselasky@c2i.net> 
wrote:
> > On Saturday 03 January 2009, Volker wrote:
> >> On 01/03/09 01:35, Hans Petter Selasky wrote:
> >> > On Wednesday 31 December 2008, vwe@freebsd.org wrote:
> >> >> Synopsis: [newusb] usbconfig(8) fails with misleading error when run
> >> >> as a normal user
> >> >>
> >> >> Responsible-Changed-From-To: freebsd-bugs->freebsd-usb
> >> >> Responsible-Changed-By: vwe
> >> >> Responsible-Changed-When: Wed Dec 31 12:55:52 UTC 2008
> >> >> Responsible-Changed-Why:
> >> >> reassign
> >> >>
> >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=129963
> >> >
> >> > Hi,
> >> >
> >> > "usbconfig" will only show USB devices which the user has access to.
> >> >
> >> > What should be the correct display message when no devices are
> >> > accessible due to innsufficient permissions?
> >> >
> >> > --HPS
> >>
> >> Hans,
> >>
> >> what about "access denied" or "insufficient privileges"?
> >>
> >> Someone might have a better idea but everything should be better than
> >> silently refusing to do anything.
> >>
> >> Volker
> >
> > Is this Ok:
> >
> > http://perforce.freebsd.org/chv.cgi?CH=155731
> >
> > --HPS
>
> Eh? I still think that strerror or something along those lines would
> be more helpful.

Hi,

If errno != 0, I could print out the current value like a string.

>
> You could also do
>
> if (getuid() != 0) {
>     errx(1, "Cluebat -- you might not be able to read the usb devices
> if you're not root");
> }

Yes, but you are allowed to give non-root users access to USB aswell. So that 
would also be misleading.

Would something like counting the number of devices you don't have access to 
be Ok?

usbconfig
ugenX.Y....
There are xxx USB devices not listed which require root access.

>
> or...
>
> struct stat usb_s;
>
> int fd = open(..., O_RDONLY /* blah, blah... */);
>
> if (fd == -1) {
>     errx(1, "Does the file -- %s -- exist?", file);
> }
>
> if (fstat(fd, &usb_s) == -1) {
>     errx(1, "Couldn't stat the file: %s", file);
> }
>
> if (!S_IRUSR(usb_s.st_mode) && !S_IRGRP(usb_s.st_mode) &&
> !S_IROTH(usb_s.st_mode)) {
>     errx(1, "File not readable (do you have read permissions?)");
> }
>
> /* Continue on merry way reading devices; maybe use strerror(3) for
> more intuitive error messages? */
>
> Thoughts?

It has to fit into libusb20 ... That's all.

--HPS