From owner-svn-src-user@freebsd.org Tue Jan 9 21:54:38 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA718E75528 for ; Tue, 9 Jan 2018 21:54:38 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 930C873874; Tue, 9 Jan 2018 21:54:38 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CFDED1CC40; Tue, 9 Jan 2018 21:54:37 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w09LsbjE024434; Tue, 9 Jan 2018 21:54:37 GMT (envelope-from jeff@FreeBSD.org) Received: (from jeff@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w09Lsb69024433; Tue, 9 Jan 2018 21:54:37 GMT (envelope-from jeff@FreeBSD.org) Message-Id: <201801092154.w09Lsb69024433@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jeff set sender to jeff@FreeBSD.org using -f From: Jeff Roberson Date: Tue, 9 Jan 2018 21:54:37 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r327749 - user/jeff/numa/sys/dev/acpica X-SVN-Group: user X-SVN-Commit-Author: jeff X-SVN-Commit-Paths: user/jeff/numa/sys/dev/acpica X-SVN-Commit-Revision: 327749 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 21:54:38 -0000 Author: jeff Date: Tue Jan 9 21:54:37 2018 New Revision: 327749 URL: https://svnweb.freebsd.org/changeset/base/327749 Log: Review feedback from jhb. Cleaner initialization. Don't leak a tag on error. Modified: user/jeff/numa/sys/dev/acpica/acpi_pcib_acpi.c Modified: user/jeff/numa/sys/dev/acpica/acpi_pcib_acpi.c ============================================================================== --- user/jeff/numa/sys/dev/acpica/acpi_pcib_acpi.c Tue Jan 9 21:37:35 2018 (r327748) +++ user/jeff/numa/sys/dev/acpica/acpi_pcib_acpi.c Tue Jan 9 21:54:37 2018 (r327749) @@ -542,7 +542,7 @@ acpi_pcib_acpi_attach(device_t dev) acpi_pcib_fetch_prt(dev, &sc->ap_prt); error = bus_dma_tag_create(bus_get_dma_tag(dev), 1, - PCI_DMA_BOUNDARY, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, + 0, BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXSIZE, BUS_SPACE_UNRESTRICTED, BUS_SPACE_MAXSIZE, 0, NULL, NULL, &sc->ap_dma_tag); if (error != 0) @@ -555,6 +555,8 @@ acpi_pcib_acpi_attach(device_t dev) bus_generic_probe(dev); if (device_add_child(dev, "pci", -1) == NULL) { + bus_dma_tag_destroy(sc->ap_dma_tag); + sc->ap_dma_tag = NULL; error = ENXIO; goto errout; }