From owner-cvs-all@FreeBSD.ORG Fri Apr 8 17:52:47 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E28F106566C; Fri, 8 Apr 2011 17:52:47 +0000 (UTC) (envelope-from bf1783@googlemail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 451858FC17; Fri, 8 Apr 2011 17:52:47 +0000 (UTC) Received: by pvg11 with SMTP id 11so1722547pvg.13 for ; Fri, 08 Apr 2011 10:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=ByFiFDj3WcCSW60fJRrCnQq+s0Li1np0G2PU2ZT+RJg=; b=PrGeWPfI5rry2gCyLArRIvE0AT+doxy+SC6mAbINNGjA3fvAa32vx+EEnnhJCPaa99 kah9SUhRbO+OWBNTnpP8tcTiIvqvQGecMU7E+zsdhuNkAUYPfwbWn5wo6F2irJlVzzN6 w3w2HvAU5jb6uqFYlQRznlGPITfh+CQz43iO8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; b=WUYScfG2XONTX+wzR3fRmPAxkguYksucWQJAHi3lCTU+akDU8q92+o5kuSRTnwu/Ku hydLBI9OqYfOaJZS5Gc4v6cuyUMzYxzpmDUNYzijKvoS6A8iRjsvKfTbqNqg1IiL8hDK Ba3cuWK3+/X80VDQZQq4VPB7Op0PKRXebTuWk= MIME-Version: 1.0 Received: by 10.142.161.10 with SMTP id j10mr1975333wfe.250.1302285166672; Fri, 08 Apr 2011 10:52:46 -0700 (PDT) Received: by 10.68.47.6 with HTTP; Fri, 8 Apr 2011 10:52:46 -0700 (PDT) In-Reply-To: <20110408153710.GA28200@FreeBSD.org> References: <201104072239.p37Md9oh031253@repoman.freebsd.org> <20110408022459.GA40411@FreeBSD.org> <20110408023021.GA47293@FreeBSD.org> <20110408035430.GA56549@FreeBSD.org> <20110408153710.GA28200@FreeBSD.org> Date: Fri, 8 Apr 2011 17:52:46 +0000 Message-ID: From: "b. f." To: Alexey Dokuchaev Content-Type: text/plain; charset=ISO-8859-1 Cc: Rene Ladan , cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www/chromium Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: bf1783@gmail.com List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2011 17:52:47 -0000 On 4/8/11, Alexey Dokuchaev wrote: > On Fri, Apr 08, 2011 at 12:24:57PM +0000, b. f. wrote: >> I guess that we should just trust users to configure them properly. > > Yes, I also believe that if user wants to build a package for machine other > than theirs, they are expected to know how these things work and what to do > to get the work done. From our side, we should provide easy and straight- > forward means of such customizations. > > Summarizing our discussion, what do you think of the following? > > .if ! ${MACHINE_CPU:Msse2} || defined(PACKAGE_BUILDING) && ${ARCH} != > "amd64" > GYP_DEFINES+= disable_sse2=1 > .endif > > Default package would have reasonable defaults now, custom port build can > be controlled by passing desired MACHINE_CPU. Building SSE2-enabled > package for i386 is a bit tricky, but cannot be possibly polluted by > stale cached OPTIONS value. Sorry, I tried to convey in my previous message that I was mistaken in thinking that the earlier changes would cause problems for the default i386 packages. Packages for the machine hosting the build, and those built for generic machines via the portbuild scripts, have the right settings now, so I would leave the port as it is. As you wrote, those who are building packages for machines other than the host should ensure that CPUTYPE has the desired value (they should also ensure that all OPTIONS and other relevant variables in included Makefiles have the desired values, so the argument about build pollution for only this knob is a bit overstated), so I think that adding the change above just creates an unnecessary obstacle to building SSE2-enable packages on i386 when such a build is desired. b.