From owner-freebsd-bugs@FreeBSD.ORG Mon Feb 2 18:34:59 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D37716A4CE; Mon, 2 Feb 2004 18:34:59 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7D0B43D1D; Mon, 2 Feb 2004 18:34:57 -0800 (PST) (envelope-from iedowse@FreeBSD.org) Received: from freefall.freebsd.org (iedowse@localhost [127.0.0.1]) i132YvFR010447; Mon, 2 Feb 2004 18:34:57 -0800 (PST) (envelope-from iedowse@freefall.freebsd.org) Received: (from iedowse@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i132YvB1010443; Mon, 2 Feb 2004 18:34:57 -0800 (PST) (envelope-from iedowse) Date: Mon, 2 Feb 2004 18:34:57 -0800 (PST) From: Ian Dowse Message-Id: <200402030234.i132YvB1010443@freefall.freebsd.org> To: czang@panasas.FreeBSD.ORG, iedowse@FreeBSD.org, freebsd-bugs@FreeBSD.org, iedowse@FreeBSD.org Subject: Re: kern/62278: NFS server may not set eof flag when reading last chunk of file X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 02:34:59 -0000 Synopsis: NFS server may not set eof flag when reading last chunk of file State-Changed-From-To: open->analyzed State-Changed-By: iedowse State-Changed-When: Mon Feb 2 18:29:36 PST 2004 State-Changed-Why: This has already been fixed in FreeBSD 5.2 and FreeBSD 4.9, but I think your patch possibly results in more correct behaviour than the current code (your patch returns eof=true when the request ends exactly at the end of the file, whereas the current code returns false but the next read returns 0 bytes with eof=true). Responsible-Changed-From-To: freebsd-bugs->iedowse Responsible-Changed-By: iedowse Responsible-Changed-When: Mon Feb 2 18:29:36 PST 2004 Responsible-Changed-Why: I'll take this as a reminder to look at it. http://www.freebsd.org/cgi/query-pr.cgi?pr=62278