From owner-freebsd-net@FreeBSD.ORG Tue Mar 10 09:52:57 2015 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ECDF66AC for ; Tue, 10 Mar 2015 09:52:57 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D3690D7D for ; Tue, 10 Mar 2015 09:52:57 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2A9qv1M077195 for ; Tue, 10 Mar 2015 09:52:57 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 197265] [mii] patch to support rtl8211f ethernet phys Date: Tue, 10 Mar 2015 09:52:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yongari@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2015 09:52:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197265 --- Comment #4 from Pyun YongHyeon --- Thanks for the patch. I didn't test your patch on real H/W yet but patch looks good to me. To improve readability I've slightly reorganized your patch and regenerated it against HEAD. One difference against your diff is direct access of RGEPHY_F_MII_SSR register in MII_TICK handler. I wanted to remove RGEPHY_MII_BMSR, RGEPHY_MII_BMCR register accesses in the handler and rely on RGEPHY_F_MII_SSR or RGEPHY_MII_SSR register for non-re(4) drivers. Of course this assumes RGEPHY_F_MII_SSR reports correct link state in various timings. Would you try attached patch and let me know how it goes? -- You are receiving this mail because: You are the assignee for the bug.