From owner-freebsd-mobile  Wed Jan 10 10:12:15 2001
Delivered-To: freebsd-mobile@freebsd.org
Received: from mta07-svc.ntlworld.com (mta07-svc.ntlworld.com [62.253.162.47])
	by hub.freebsd.org (Postfix) with ESMTP
	id E46F637B698; Wed, 10 Jan 2001 10:11:56 -0800 (PST)
Received: from dmlb.org ([62.253.135.85]) by mta07-svc.ntlworld.com
          (InterMail vM.4.01.02.27 201-229-119-110) with ESMTP
          id <20010110181139.NOCS26323.mta07-svc.ntlworld.com@dmlb.org>;
          Wed, 10 Jan 2001 18:11:39 +0000
Received: from dmlb by dmlb.org with local (Exim 3.03 #1)
	id 14GPiw-000GLi-00; Wed, 10 Jan 2001 18:11:50 +0000
Content-Length: 1307
Message-ID: <XFMail.010110181150.dmlb@computer.my.domain>
X-Mailer: XFMail 1.3 [p0] on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200101101756.f0AHuXs63066@harmony.village.org>
Date: Wed, 10 Jan 2001 18:11:50 -0000 (GMT)
From: Duncan Barclay <dmlb@dmlb.org>
To: Warner Losh <imp@harmony.village.org>
Subject: Re: memory mapped io for Aironet driver.
Cc: mobile@FreeBSD.ORG, onoe@FreeBSD.ORG
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Hi

On 10-Jan-01 Warner Losh wrote:
> In message <XFMail.010110083625.dmlb@computer.my.domain> Duncan Barclay
> writes:
>: Sorry this is for the awi driver not aironet.
> 
> Does this have any impact on performance?  I use awi all the time.

A quick look at awi/am79c930.c says yes:

        static void io_read_bytes (sc, off, ptr, len)
        struct am79c930_softc *sc;
        u_int32_t off;
        u_int8_t *ptr;
        size_t len;
{
        int i;
        
        bus_space_write_1(sc->sc_iot, sc->sc_ioh, AM79C930_LMA_HI,
            ((off>>8)& 0x7f));
        AM930_DELAY(1);
        bus_space_write_1(sc->sc_iot, sc->sc_ioh, AM79C930_LMA_LO, (off&0xff));
        AM930_DELAY(1);
        for (i=0; i<len; i++) 
                ptr[i] = bus_space_read_1(sc->sc_iot, sc->sc_ioh,
                    AM79C930_IODPA);
}

verses

static void mem_read_bytes (sc, off, ptr, len)
        struct am79c930_softc *sc;
        u_int32_t off;
        u_int8_t *ptr;
        size_t len;
{
        bus_space_read_region_1 (sc->sc_memt, sc->sc_memh, off, ptr, len);
}

> Warner

Duncan


---
________________________________________________________________________
Duncan Barclay  | God smiles upon the little children,
dmlb@dmlb.org   | the alcoholics, and the permanently stoned.
dmlb@freebsd.org| Steven King


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message