Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 5 Jan 2025 13:54:27 GMT
From:      Dimitry Andric <dim@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org
Subject:   git: c044b16d8a34 - 2025Q1 - security/heimdal: fix with stock clang >= 16
Message-ID:  <202501051354.505DsRff044832@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch 2025Q1 has been updated by dim:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c044b16d8a349de70c18a5cb3bad45ba944524a3

commit c044b16d8a349de70c18a5cb3bad45ba944524a3
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-12-04 18:49:29 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2025-01-05 13:54:07 +0000

    security/heimdal: fix with stock clang >= 16
    
    Upstream clang >= 16 made -Wimplicit-function-declaration into an error
    by default. In the base system, this change was reverted to reduce the
    fallout in ports, because there are many problematic configure scripts.
    
    For security/heimdal this also applies, so for building the port with
    devel/llvm16 or higher we need to add -Wno-implicit-function-declaration
    to CFLAGS.
    
    While here, use LDFLAGS+= for -Wl,--undefined-version, to avoid
    overwriting any user-specified LDFLAGS.
    
    PR:             283131
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2025Q1
    
    (cherry picked from commit 4d5d01f42f436a1834773cc616fb7a693acfbc74)
---
 security/heimdal/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/security/heimdal/Makefile b/security/heimdal/Makefile
index 3508ad2f8f0c..dae850e063f3 100644
--- a/security/heimdal/Makefile
+++ b/security/heimdal/Makefile
@@ -45,7 +45,8 @@ CONFIGURE_ARGS=	--with-berkeley-db \
 		--sysconfdir="${PREFIX}/etc"
 # XXX --with-readline picks up libreadline even if found in /usr/lib.
 MAKE_ENV=	INSTALL_CATPAGES=no
-LDFLAGS=	-Wl,--undefined-version
+CFLAGS+=	-Wno-implicit-function-declaration
+LDFLAGS+=	-Wl,--undefined-version
 INSTALL_TARGET=	install-strip
 .if !exists(/etc/rc.d/ipropd_master)
 USE_RC_SUBR=	ipropd_master ipropd_slave



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202501051354.505DsRff044832>