Date: Wed, 24 Aug 2016 00:14:20 +0300 From: Andrey Chernov <ache@freebsd.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304703 - head/include/xlocale Message-ID: <48795833-b3ec-6cc3-1432-5669cc995b47@freebsd.org> In-Reply-To: <CD046664-4C4B-49CA-B005-C05EDE9694AC@gmail.com> References: <201608232033.u7NKXuZ9054093@repo.freebsd.org> <CD046664-4C4B-49CA-B005-C05EDE9694AC@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --unTFewBggW3AsdvIf70LEhoQEkkHPSfmT Content-Type: multipart/mixed; boundary="CxCUBWbJ5Na6DlBvKS8J3p2PXXnIGAT0Q"; protected-headers="v1" From: Andrey Chernov <ache@freebsd.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <48795833-b3ec-6cc3-1432-5669cc995b47@freebsd.org> Subject: Re: svn commit: r304703 - head/include/xlocale References: <201608232033.u7NKXuZ9054093@repo.freebsd.org> <CD046664-4C4B-49CA-B005-C05EDE9694AC@gmail.com> In-Reply-To: <CD046664-4C4B-49CA-B005-C05EDE9694AC@gmail.com> --CxCUBWbJ5Na6DlBvKS8J3p2PXXnIGAT0Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23.08.2016 23:53, Ngie Cooper (yaneurabeya) wrote: >=20 >> On Aug 23, 2016, at 13:33, Andrey A. Chernov <ache@FreeBSD.org> wrote:= >> >> Author: ache >> Date: Tue Aug 23 20:33:56 2016 >> New Revision: 304703 >> URL: https://svnweb.freebsd.org/changeset/base/304703 >> >> Log: >> LC_*_MASK bit shifting order was partially broken from the initial co= mmit >> time at year 2012. Only LC_COLLATE_MASK and LC_CTYPE_MASK are in the >> right order. >> >> The order here should match XLC_* from "xlocale_private.h" which, in = turn, >> match LC_* publicly visible order from <locale.h> which determines ho= w >> locale components are stored in the structure. >> LC_*_MASK -> XLC_* translation done as "ffs(mask) - 1" in the querylo= cale() >> and equivalent shift loop in the newlocale(), so mapped to some wrong= >> components (excluding two mentioned above). >> >> Formally the fix is ABI breakage, but old code using those masks >> never works properly in any case. >> Only newlocale() and querylocale() are affected. >> >> MFC after: 7 days >> >> Modified: >> head/include/xlocale/_locale.h >=20 > Should __FreeBSD_version be bumped? > Thanks, > -Ngie >=20 Yes, I'll do it later. --CxCUBWbJ5Na6DlBvKS8J3p2PXXnIGAT0Q-- --unTFewBggW3AsdvIf70LEhoQEkkHPSfmT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJXvLytAAoJEKUckv0MjfbKmMMIANIgBjua3n8uamBMzK00vhfO PfwQ/J8Ixgq90bPSyQeaR1s8mj506XG1YJG0jGIWq3/7vZaZK8nAoJUU+Imnx/sD h81zyGSU+FNInCD9SJTEws/w5dfMQxLT2E8JOJcThB81S3kURBePLCvyFaS3wVrn KisqitzNA3Oy78h3uQnFkI0PC3CH17kUlOKBX/0HMCEI7+ehiKgEtMwRQs+/tKyR R5sHE/rjj/5Dpj5UVkEqOW3IfuIhMS2yUF6J+LnlAheQjnBPKzjqV+Gmv/illAp1 taOxzBzI4L8n6o469rZzwZbh5E6WBCA1tG1h8ElOfwsv0FN9wy77/pv4PcWoWFA= =rYQ/ -----END PGP SIGNATURE----- --unTFewBggW3AsdvIf70LEhoQEkkHPSfmT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48795833-b3ec-6cc3-1432-5669cc995b47>