From owner-freebsd-multimedia Thu Mar 20 14:16: 8 2003 Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1ECFE37B401 for ; Thu, 20 Mar 2003 14:16:07 -0800 (PST) Received: from puma.icir.org (puma.icir.org [192.150.187.73]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4273343F85 for ; Thu, 20 Mar 2003 14:16:06 -0800 (PST) (envelope-from hodson@puma.icir.org) Received: from puma.icir.org (localhost [127.0.0.1]) by puma.icir.org (8.12.3/8.12.3) with ESMTP id h2KMG6AT099380; Thu, 20 Mar 2003 14:16:06 -0800 (PST) (envelope-from hodson@puma.icir.org) Message-Id: <200303202216.h2KMG6AT099380@puma.icir.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.3 To: Joel Ray Holveck Cc: freebsd-multimedia@FreeBSD.ORG From: Orion Hodson Subject: Re: How to handle sound card patches? In-Reply-To: Your message of "20 Mar 2003 13:19:43 PST." <87isudsplc.fsf@thor.piqnet.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 20 Mar 2003 14:16:06 -0800 Sender: owner-freebsd-multimedia@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org /-- Joel Ray Holveck wrote: | I have a problem. The csa bridge driver breaks if I try to attach the | MIDI port on my Turtle Beach Santa Cruz. I traced the problem to a | problem with the interrupt, and patched it. | | The problem is, it looks like the interrupt used to be handled the way | my new code does it, and was intentionally changed. This was in a | batch of changes, so the CVS log is not very enlightening. | | So, now I have a patch to the sound driver that is required to make it | work on my sound card, but will possibly break other CSA-based sound | cards. | | Surely this comes up often, since the same driver is used for many | different sound cards. What has the FreeBSD multimedia community done | to handle this sort of situation in the past? What is the right way | to test this patch before I send a PR? Just submit the pr with the patch and explanation. Label it clearly as a sound issue and the gnats submission folks should make sound@freebsd.org responsible for the problem. The sound committers get to see your pr submission when it happens and get reminded about it by an automated process every two weeks. If you haven't seen any action within a couple of weeks or it doesn't get assigned to sound@freebsd.org, send a (gentle) reminder to sound@freebsd.org. Depending on the size and scope of the patch, it makes life easier in sound@ if the patch is relative to -CURRENT. Regards - Orion To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-multimedia" in the body of the message