From owner-freebsd-ports Tue Aug 6 10:40:15 2002 Delivered-To: freebsd-ports@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C922F37B400 for ; Tue, 6 Aug 2002 10:40:02 -0700 (PDT) Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E956143E88 for ; Tue, 6 Aug 2002 10:40:01 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g76He1JU086254 for ; Tue, 6 Aug 2002 10:40:01 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g76He1QM086253; Tue, 6 Aug 2002 10:40:01 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4449F37B400 for ; Tue, 6 Aug 2002 10:37:51 -0700 (PDT) Received: from astart2.astart.com (adsl-63-200-201-186.dsl.sndg02.pacbell.net [63.200.201.186]) by mx1.FreeBSD.org (Postfix) with ESMTP id B16C343E6E for ; Tue, 6 Aug 2002 10:37:50 -0700 (PDT) (envelope-from papowell@astart.com) Received: from h110.private (h110.private [10.0.0.110]) by astart2.astart.com (8.11.6/8.11.6) with ESMTP id g76Hboc37780 for ; Tue, 6 Aug 2002 10:37:50 -0700 (PDT) (envelope-from papowell@astart.com) Received: (from papowell@localhost) by h110.private (8.11.6/8.11.6) id g76Hbo100908; Tue, 6 Aug 2002 10:37:50 -0700 (PDT) (envelope-from papowell) Message-Id: <200208061737.g76Hbo100908@h110.private> Date: Tue, 6 Aug 2002 10:37:50 -0700 (PDT) From: Patrick Powell Reply-To: Patrick Powell To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/41385: mysql server startup script has syntax error Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 41385 >Category: ports >Synopsis: mysql server startup script has syntax error >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Aug 06 10:40:01 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Patrick Powell >Release: FreeBSD 4.6-RELEASE i386 >Organization: Astart Technologies >Environment: System: FreeBSD h110.private 4.6-RELEASE FreeBSD 4.6-RELEASE #0: Thu Apr 25 16:13:58 PDT 2002 papowell@h110.private:/usr/src/sys/compile/TEST i386 >Description: file: /usr/ports/databases/mysql323-server/file/mysql-server.sh See the lines indicated below. #!/bin/sh case "$1" in start) if [ -x %%PREFIX%%/bin/safe_mysqld ]; then %%PREFIX%%/bin/safe_mysqld --user=mysql > /dev/null & && echo -n ' mysqld' *********************************************************** ^^^^^ syntax error *********************************************************** & is valid fi ;; stop) /usr/bin/killall mysqld > /dev/null 2>&1 && echo -n ' mysqld' ;; *) echo "" echo "Usage: `basename $0` { start | stop }" echo "" exit 64 ;; esac In 4.6-RELEASE and earlier versions the sequence 'command & && command' was allowed by the /bin/sh program. However, as of 4.6-STABLE (updated using CVS) this sequence is no longer valid. >How-To-Repeat: Install the port on different systems. Your startup script will fail. >Fix: Patch: *** files/mysql-server.sh Tue Aug 6 10:27:53 2002 --- files/mysql-server.sh.orig Tue Aug 6 10:26:54 2002 *************** *** 3,9 **** case "$1" in start) if [ -x %%PREFIX%%/bin/safe_mysqld ]; then ! %%PREFIX%%/bin/safe_mysqld --user=mysql > /dev/null & echo -n ' mysqld' fi ;; stop) --- 3,9 ---- case "$1" in start) if [ -x %%PREFIX%%/bin/safe_mysqld ]; then ! %%PREFIX%%/bin/safe_mysqld --user=mysql > /dev/null & && echo -n ' mysqld' fi ;; stop) >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message