From owner-svn-src-all@FreeBSD.ORG  Sun Sep  7 05:44:46 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E54BE3B5;
 Sun,  7 Sep 2014 05:44:46 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 68B1713A3;
 Sun,  7 Sep 2014 05:44:45 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s875ibUK026979
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 7 Sep 2014 09:44:37 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s875ibJn026978;
 Sun, 7 Sep 2014 09:44:37 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sun, 7 Sep 2014 09:44:37 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Subject: Re: svn commit: r271182 - head/sys/kern
Message-ID: <20140907054437.GI17059@FreeBSD.org>
References: <201409051950.s85JoI3r000416@svn.freebsd.org>
 <20140905195410.GA722@dft-labs.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140905195410.GA722@dft-labs.eu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Sep 2014 05:44:47 -0000

On Fri, Sep 05, 2014 at 09:54:11PM +0200, Mateusz Guzik wrote:
M> > +	CURVNET_SET(so->so_vnet);
M> >  	if (V_socket_hhh[HHOOK_FILT_SOREAD]->hhh_nhooks > 0)
M> >  		/* This hook returning non-zero indicates an event, not error */
M> >  		return (hhook_run_socket(so, NULL, HHOOK_FILT_SOREAD));
M> > +	CURVNET_RESTORE();
M> >  	
M> 
M> should not this be something like:
M> 		error = hhook_run_socket(so, NULL, HHOOK_FILT_SOREAD);
M> 		CURVNET_RESTORE();
M> 		return (error);
M> ?

Thanks, Mateusz. Fixed.

-- 
Totus tuus, Glebius.