From owner-freebsd-ports@FreeBSD.ORG  Sat Jun 23 01:14:02 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id 104AE106566B;
	Sat, 23 Jun 2012 01:14:02 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 1DBCC151F10;
	Sat, 23 Jun 2012 01:14:01 +0000 (UTC)
Message-ID: <4FE51858.4010502@FreeBSD.org>
Date: Fri, 22 Jun 2012 18:14:00 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:13.0) Gecko/20120621 Thunderbird/13.0.1
MIME-Version: 1.0
To: FreeBSD Ports <ports@FreeBSD.org>
References: <4FE12F2D.9080302@FreeBSD.org>
	<20120620061136.GA79164@ithaqua.etoilebsd.net>
	<4FE1829D.6030109@FreeBSD.org>
	<20120620091321.GA83730@ithaqua.etoilebsd.net>
	<20120620094431.M12775@martymac.org>
	<20120620103412.GB83730@ithaqua.etoilebsd.net>
	<4FE1C1EA.8070901@FreeBSD.org> <20120621090226.M48537@FreeBSD.org>
	<4FE4AEFC.4070405@FreeBSD.org>
In-Reply-To: <4FE4AEFC.4070405@FreeBSD.org>
X-Enigmail-Version: 1.4.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Olli Hauer <ohauer@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>,
	Ganael LAPLANCHE <martymac@FreeBSD.org>,
	Matthew Seaman <matthew@FreeBSD.org>,
	Michael Scheidell <scheidell@FreeBSD.org>
Subject: Re: optionsng and tinderbox?
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jun 2012 01:14:02 -0000

On 06/22/2012 10:44, Olli Hauer wrote:
> On 2012-06-21 11:26, Ganael LAPLANCHE wrote:
>> On Wed, 20 Jun 2012 13:28:26 +0100, Matthew Seaman wrote
>>
>> Hi Matthew, Baptiste,
>>
>> Thank you very much for your answers.
>>
>> With your patch, Matthew, setting :
>>
>> openldap24-client_SET+=FETCH
>>
>> in make.conf now works for net/openldap24-client :
>>
>> $ cd /usr/ports/net/openldap24-client
>> $ make -V PORT_OPTIONS
>> DOCS EXAMPLES FETCH NLS
>>
>> Great :)
>>
>>> [...]
>>> Shouldn't make.conf / commandline settings override OPTIONSFILE rather
>>> than the other way round?  Seems there's not much point in being able to
>>> set options from make.conf unless that is so, as OPTIONSFILE would be
>>> created more often than not whenever make(1) was invoked in the port's
>>> directory.
>>
>> I think that command-line options should always override file ones, but
>> the main problem here is that we cannot distinguish what comes from the
>> command line from what comes from make.conf.
>>
>> What would sound logical to me would be the following order of precedence :
>>
>> make.conf -> overridden by option files -> overridden by command line
> 
> 
> This looks wrong to me.
> 
> Options set in make.conf should not be overwritten by the option file
> else you don't need etc/make.conf at all.

Right. make.conf and options files should be flipped in the example above.


Doug

-- 

    This .signature sanitized for your protection