From owner-svn-src-head@freebsd.org Tue Mar 7 05:07:20 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61CE5D01D19; Tue, 7 Mar 2017 05:07:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2E9C01954; Tue, 7 Mar 2017 05:07:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x243.google.com with SMTP id o126so5688012pfb.1; Mon, 06 Mar 2017 21:07:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=wxd7P4fZZxulRbw64xnaMDWp86o3jZUaV4VM28+gkzA=; b=QBbFebskeKCNot36FAa4MmPCIHR47fmAIJ6BZRSk08Y2s6QWbIbM80uenSx2oIgIq2 X54JHAf7pX2UHgTl7rLMhQJSs11MDjrL4glr/4nSydg9UUas4nCjffCpFQkSBQmfUMKx RUqKqtP4Hdae2ZuVwgmdP1MXpSpwhKfVjkHrG01sdQRD9jb1szbjuqd6rlYFwGWxHvOM XPbZQTVtY5zdDlvXHtYonxxXXGarNBJFWReHrk8qfXqvGdeZcpBc36W6SdvvxeVdUbzY G8wV6AeIS2xGTCrcO7EFnYgd+wQpHs+DGviG0OqRs7fNeMW8QoZfhDGMrf2BLEPQAcqQ FWtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=wxd7P4fZZxulRbw64xnaMDWp86o3jZUaV4VM28+gkzA=; b=aixxXxH6V+xX5/ku8YHIv9uneHNQXjri4Vx0YfCVecdSusYmyqiU6PqmCt0srlFfIV yNHbHqsosVGHNKAOywvb8xBtlLhWvRCB6dVI0F7HPiO6sbQIxhEBQxS+9/CesvgWlvtN OJt4t6+F/EkokFwKOBlt3RnKQ5QUABBH0DRXixrQGqUUge05VBR2/BCovMzfwnaHllVQ 3LHtMgTI7gPOuSS3dvKTddigmtli9T+NehThI4T9RalZ7gQu93WGliek+9lbm6807VQ/ 74L0bUgs5ReUWF0llf3taaHtOqkGR6JamEf0kIIX70reNrtXNNsemKV+FDuZSPwH3goo roHw== X-Gm-Message-State: AMke39m6ehPlDCL+Cwli+LdrXOpe5nVh4xyrKQP7E/1wknXZXDw8g78Loq6zAKELEqeyYg== X-Received: by 10.98.67.193 with SMTP id l62mr25563663pfi.148.1488863239515; Mon, 06 Mar 2017 21:07:19 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id c1sm42533068pfk.112.2017.03.06.21.07.18 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Mar 2017 21:07:18 -0800 (PST) Subject: Re: svn commit: r314831 - head/usr.bin/fortune Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_103D9FF1-644D-4568-8118-913F38E8E55F"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Mon, 6 Mar 2017 21:07:18 -0800 Cc: Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201703070500.v2750Qqd092455@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 05:07:20 -0000 --Apple-Mail=_103D9FF1-644D-4568-8118-913F38E8E55F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 6, 2017, at 21:01, Ngie Cooper (yaneurabeya) = wrote: >=20 >=20 >> On Mar 6, 2017, at 21:00, Rodney W. Grimes = wrote: >>=20 >> [ Charset UTF-8 unsupported, converting... ] >>> Author: ngie >>> Date: Tue Mar 7 04:33:17 2017 >>> New Revision: 314831 >>> URL: https://svnweb.freebsd.org/changeset/base/314831 >>>=20 >>> Log: >>> Don't rely on dependency in Makefile.inc1 for strfile; make datfiles = depend on strfile >>>=20 >>> In most cases strfile is built as part of build-tools, but in the = event that someone >>> cd'ed to the directory, tried to build from scratch, and had = MK_GAMES=3Dno previously, >>> the build would fail in .../datfiles , trying to find strfile . >>>=20 >>> Mark this directory tree "SUBDIR_PARALLEL" safe to help facilitate = this, instead of >>> shuffling around the SUBDIR entries (all of the other Makefiles will = build standalone). >>>=20 >>> MFC after: 1 week >>> Sponsored by: Dell EMC Isilon >>>=20 >>> Modified: >>> head/usr.bin/fortune/Makefile >>>=20 >>> Modified: head/usr.bin/fortune/Makefile >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/usr.bin/fortune/Makefile Tue Mar 7 04:13:22 2017 = (r314830) >>> +++ head/usr.bin/fortune/Makefile Tue Mar 7 04:33:17 2017 = (r314831) >>> @@ -1,5 +1,11 @@ >>> # @(#)Makefile 8.1 (Berkeley) 5/31/93 >>> +# >>> +# $FreeBSD$ >>>=20 >>> -SUBDIR=3D fortune strfile datfiles unstr >>> +SUBDIR=3D fortune strfile datfiles unstr >>> + >>> +SUBDIR_DEPEND_datfiles=3D strfile >> That should be a space, variable ends past column 9. >=20 > "An ASCII space is allowed for variable names that extend beyond = column 9. =E2=80=9C >=20 > "is allowed=E2=80=9D !=3D =E2=80=9Cmust=E2=80=9D. And being extremely aesthetically nitpicky, as the queer person I am = with my attention to colors and design (:P..), I would be kind of = annoyed with right hand sides being unaligned, e.g., SOMETHING_REALLY_LONG=3D foo # 1 hard tab SOMETHING_SHORTER=3D bar # 2 hard tabs vs SOMETHING_REALLY_LONG=3D foo # 1 space SOMETHING_SHORTER=3D bar # 2 spaces --Apple-Mail=_103D9FF1-644D-4568-8118-913F38E8E55F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvkAGAAoJEPWDqSZpMIYVy3wP/2+hrG3RZvJOSH68V9whb5DA 8LK8eOs1Z+YMmbtX0JCc6Zr5MUcAMg/Ta3LlLQXpnOtF7n3otswLS37LJoZKNU/O 1CUK90mMeSlAEysjvprg7NW9rxyxceJEcm/ClyLDMImzbSMSHnlCkO7yYxhr/ZGw kZ1dC1mI2I3bWtzPrjDou4eLQGD5If68oJLlrJi+q0grWdHo9io30UVz/snrC9Y3 LIyqyiYdFLS8kYxwMs7GQG1WNH3nFKokuuovLxQwWL4n2Rt084DBdAWMP0sQ3Bw5 HkDlMY15mdQ+WjomD8dZG3uW4csweTZCWxmzQd5mRb+/cKdukharlv8BF0yellOJ i1M5MLIsG0k8VrhuqrWkIG35AbS6a5FsLffIDn+LzoGuGNdvYHiyXJWsFk16H+i2 j/jt31sFlMW/43P4OROxjjj8tvIb29BDeEVXhFX4pSYD9wXKB3dj5t87GViXkji9 /ttKtBCZ73WBQ2wk4n9mbwsDCdS3n/0oKo0hyP/eWSa2+t0zfOTRdzGpF72/4SD7 Fukw0avklGuf3w5q6SlsInnBusLcX/bTCDpb0y6LoyzP+7fqhzzj8m2qncoOMEWd e7l7yeCQhqIUAP+aWoj7oX1F2Ibzbhdwutn5FcQZh5WJhnUA+z4tkjPnGDScswnR i3Ipxcmf4iHMkSwXdxZN =eYIY -----END PGP SIGNATURE----- --Apple-Mail=_103D9FF1-644D-4568-8118-913F38E8E55F--