From owner-cvs-all Tue Apr 9 13:27:41 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by hub.freebsd.org (Postfix) with ESMTP id D975237B416 for ; Tue, 9 Apr 2002 13:27:30 -0700 (PDT) Received: (qmail 11044 invoked from network); 9 Apr 2002 20:27:29 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail13.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 9 Apr 2002 20:27:29 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g39KSHv50041; Tue, 9 Apr 2002 16:28:17 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020409131837.D35868@dragon.nuxi.com> Date: Tue, 09 Apr 2002 16:27:20 -0400 (EDT) From: John Baldwin To: "David O'Brien" Subject: Re: cvs commit: src/sys/sys ioccom.h Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, kris@obsecurity.org, "M. Warner Losh" , Alfred Perlstein Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 09-Apr-2002 David O'Brien wrote: > On Mon, Apr 08, 2002 at 11:42:42PM -0700, Alfred Perlstein wrote: >> > : No, I already said that I reverted the ()'s locally and it still failed >> > : to >> > : compile. Yes, I was editing /usr/include/sys/ioccom.h and not >> > : /sys/sys/ioccom.h. I also tried putting __P() back in, but it didn't >> > : build >> > : then either. I'm wondering if the pollution in screen's osdef.h is new? > ... >> > The real problem is at osdef.h:81: >> > extern int ioctl __P((int, int, char *)); >> > >> > Note the two problems with this: >> > 1) int doesn't match unsgined long >> > 2) char * doesn't match ... >> > >> > screen needs to be fixed. here's a real patch: > ... >> I don't have the emails offhand, but the screen people were pretty >> quick to respond to a help message from me. Have you contacted them >> about bringing in this fix? > > While fixing screen is a good thing to do. Nobody seems to be able to > determine just WHICH commit broke building it. I think we should determine > that before "fixing" it. Warner did already. The de- __P()'ing did because the regex they use to find function prototypes in the system headers didn't match the de- __P()'d prototypes. This was the same breakage that broke hylafax and vim according to Warner's earlier e-mail. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message