Date: Tue, 05 May 2015 16:34:37 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199938] games/wxlauncher: drop DISTNAME hack for USE_GITHUB Message-ID: <bug-199938-13-yeuDdVPMm2@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-199938-13@https.bugs.freebsd.org/bugzilla/> References: <bug-199938-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199938 --- Comment #2 from lightside <lightside@gmx.com> --- I need to say, that what I said in comment #1 is nothing personal. The current implementation of USE_GITHUB, related to MASTER_SITES, is acceptable. This is just a DISTNAME part, which is questionable. The external changes to DISTNAME (because of undefined in the port) caused a re-creation of many patches for PRs, where I participated. There was a need to generate a new distinfo file(s) for the patch(es) to work on the latest changes of ports framework. Therefore, defining the DISTNAME inside of a port safeguards the patches from re-creation (at least to the time, before _GH* suffix changes). In my opinion, the DISTNAME should be stable, which is needed for "stable" patches, available backup solutions, etc. There are solutions inside of the port to resolve possible collisions between distfiles (DIST_SUBDIR, DISTVERSIONSUFFIX, etc.), without the need to cope with external DISTNAME changes. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199938-13-yeuDdVPMm2>