From nobody Sat Nov 8 15:06:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d3fQ63r8Cz6G7JX; Sat, 08 Nov 2025 15:06:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d3fQ62s8Pz3K9B; Sat, 08 Nov 2025 15:06:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762614366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DVJectwAmEm48BiB3sULHVyOTNqe2vhJ06r/VozPNzs=; b=UF96/IqEZCI5CZooyozwX2yuID3Awb3RWzuq7okHlUqO8RDOpQ68kfJa+AhUCCUgK9SUiK 3fTcXHPxGdKKkUVaKprhWywDwb4/xMw+WNyOzFwyaOjvUsWGwda1xavJECWd+lZimLIxf2 GULaISEANeEfKgG6+H7pGzm8Fh1Pz8ATFrGdePbHel98/32y3Bxe9RLF2F/qDDUGZJmdqa EX+bRl9Ib1WOT+8ixSPlKixM2fzsSB0HTGiZDiD5PUIRi+YbRIo4xd2OWopEJPS833RdJI 8Qe9uHj/eceZfZ2p8W6hSUoLrLNu6jSwKQNYUDBPPIs1SvLRY7DY1mwgHFPhWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762614366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DVJectwAmEm48BiB3sULHVyOTNqe2vhJ06r/VozPNzs=; b=C6d5d+iY4o/BnRA7hUHd2Trs/UtyFI+EaE7Ukk+Jrm7ekY6piPQHS49C54oEycqSsnGQEI 2GvHhYxLlfUCrJebFgWKAToeCxGml2LncOYvNHSf6zpVde3dRVFfjbvrXqbQieNKRmj5hf 1ZjLBkJPuZfn5PwH+Nd0FFaggqKDd4Ba+vqSXA6IBRnTCC5CiKPFIXeQAIaZMRGAwssj7k BoaKXSKwxeec1SXpcqhPSKU/SabOmdyPyJrRljhoWq9yBftFlNDYjVQzzzFcB59HijXQSa /NhNasfOJO1h0wAQj+w5JkGe1hNW72RHdqTh4+6rusL8VdOX9RpaOmZOrFr0zQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762614366; a=rsa-sha256; cv=none; b=HQnyiiLmHdAbhE4s+Yo4bnnL3Ul0VF8G6+E4g7I4bh/PRTHxwaLHkdQKZsxiQE6R95EB/+ yEU+CavihLwylowYPXwNdXWJVHOAplFixdRYtJUbS2NuFXT1OsbYBMWQ9jjLoHqduO4l45 Q+zrB1PoQJuVhW5QB64pubcm6d6GOdOWzYzBFDIK8UiYQdyFnvsEpRq6+itZT5xdlhC5h/ b3l4/jlmNrc2CFt0zNoNy68iJ56lN869p4lD4Gd0IvP1sF5rlFXhLY583iORBUH8K75yuD ahlJ/YTnCXfReIyd5otZrejngzaO12DoxvCTCzJGDZ8Asqn68tEr2jjjlNK92Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d3fQ61f6DzqnM; Sat, 08 Nov 2025 15:06:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5A8F66d5022434; Sat, 8 Nov 2025 15:06:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5A8F66Qr022431; Sat, 8 Nov 2025 15:06:06 GMT (envelope-from git) Date: Sat, 8 Nov 2025 15:06:06 GMT Message-Id: <202511081506.5A8F66Qr022431@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 4e3694242071 - main - bsdinstall: Fix newfs bsddialog menu List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4e36942420712c2ab6ebc2c646e61d47b2b68e7b Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=4e36942420712c2ab6ebc2c646e61d47b2b68e7b commit 4e36942420712c2ab6ebc2c646e61d47b2b68e7b Author: Ed Maste AuthorDate: 2025-11-07 22:53:01 +0000 Commit: Ed Maste CommitDate: 2025-11-08 15:01:35 +0000 bsdinstall: Fix newfs bsddialog menu The second and third members of struct bsddialog_menuitem are `bool on` and `unsigned int depth`. The newfs dialog options in bsdinstall's partition tool had these two swapped, so the default selection did not work. PR: 290857 Reviewed by: asiciliano Fixes: 50e244964e9b ("bsdinstall/partedit: Replace libdialog with libbsddialog") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53639 --- usr.sbin/bsdinstall/partedit/gpart_ops.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/usr.sbin/bsdinstall/partedit/gpart_ops.c b/usr.sbin/bsdinstall/partedit/gpart_ops.c index 0bcd17950daf..8da85a805545 100644 --- a/usr.sbin/bsdinstall/partedit/gpart_ops.c +++ b/usr.sbin/bsdinstall/partedit/gpart_ops.c @@ -139,16 +139,16 @@ newfs_command(const char *fstype, int use_default) } else if (strcmp(fstype, "freebsd-zfs") == 0) { int i; struct bsddialog_menuitem items[] = { - {"", 0, true, "fletcher4", "checksum algorithm: fletcher4", + {"", true, 0, "fletcher4", "checksum algorithm: fletcher4", "Use fletcher4 for data integrity checking. " "(default)"}, - {"", 0, false, "fletcher2", "checksum algorithm: fletcher2", + {"", false, 0, "fletcher2", "checksum algorithm: fletcher2", "Use fletcher2 for data integrity checking. " "(not recommended)"}, - {"", 0, false, "sha256", "checksum algorithm: sha256", + {"", false, 0, "sha256", "checksum algorithm: sha256", "Use sha256 for data integrity checking. " "(not recommended)"}, - {"", 0, false, "atime", "Update atimes for files", + {"", false, 0, "atime", "Update atimes for files", "Disable atime update"}, }; @@ -188,11 +188,11 @@ newfs_command(const char *fstype, int use_default) strcmp(fstype, "ms-basic-data") == 0) { int i; struct bsddialog_menuitem items[] = { - {"", 0, true, "FAT32", "FAT Type 32", + {"", true, 0, "FAT32", "FAT Type 32", "Create a FAT32 filesystem (default)"}, - {"", 0, false, "FAT16", "FAT Type 16", + {"", false, 0, "FAT16", "FAT Type 16", "Create a FAT16 filesystem"}, - {"", 0, false, "FAT12", "FAT Type 12", + {"", false, 0, "FAT12", "FAT Type 12", "Create a FAT12 filesystem"}, };