From owner-cvs-all Tue May 14 14:28:51 2002 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id E1E3B37B409; Tue, 14 May 2002 14:28:45 -0700 (PDT) Received: (from joerg@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g4ELSjP70451; Tue, 14 May 2002 14:28:45 -0700 (PDT) (envelope-from joerg) Message-Id: <200205142128.g4ELSjP70451@freefall.freebsd.org> From: Joerg Wunsch Date: Tue, 14 May 2002 14:28:45 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/isa fd.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG joerg 2002/05/14 14:28:45 PDT Modified files: sys/isa fd.c Log: After some comments from bde, rewrite the loops to avoid turning the previously used "micro-optimization" (count-down loop) into a pessimization. Now the loops are written in the more natural count-up form. Also, while being there, i made the logic in out_fdc() similar to the logic in in_fdc(). The old implementation was a bit bogus anyway since it first tested the DIO bit and only afterwards the RQM bit. However, according to the description of the i82077, the DIO bit is only guaranteed to be valid once the RQM bit is set. Thus, the old implementatoin would have had the chance to misbehave on a controller that is implemented in accordance with the i82077 description (but is not bug-for-bug compatible). MFC after: 3 days Revision Changes Path 1.233 +28 -42 src/sys/isa/fd.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message