From owner-svn-src-all@FreeBSD.ORG  Fri Jan  3 21:10:59 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 470B45E2;
 Fri,  3 Jan 2014 21:10:59 +0000 (UTC)
Received: from mrout2-b.corp.bf1.yahoo.com (mrout2-b.corp.bf1.yahoo.com
 [98.139.253.105])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 017AA12F5;
 Fri,  3 Jan 2014 21:10:58 +0000 (UTC)
Received: from [127.0.0.1] (rideseveral.corp.yahoo.com [10.73.160.231])
 by mrout2-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id
 s03L0Lov007453; Fri, 3 Jan 2014 13:00:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com;
 s=cobra; t=1388782822;
 bh=zwtc+bf3uNOVL/8ZmCaxRnCWDq+xvTLYl3thNROvYf8=;
 h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date:
 Message-ID:Mime-Version:Content-Transfer-Encoding;
 b=WOep+/I7thYeYIHUKnvCvF8MdCwOSts2zj1FSHwMnGfoSUEGw93135M8Iy7Ly0BcL
 RjF+qp7SSwcS+ca3tNFSqag3VcBKyxKJ24U/+fyQP6ejgveRhIg4Raf6ni/qoB7cRO
 R0Vgv7wY9AZZkMoYDZjPVRfltT5XPVe6zLpJZV1E=
Subject: Re: svn commit: r260243 - head/sys/dev/aacraid
From: Sean Bruno <seanbru@yahoo-inc.com>
To: Sean Bruno <sbruno@FreeBSD.org>
In-Reply-To: <201401032045.s03KjuZv037787@svn.freebsd.org>
References: <201401032045.s03KjuZv037787@svn.freebsd.org>
Content-Type: text/plain; charset="us-ascii"
Date: Fri, 03 Jan 2014 13:00:20 -0800
Message-ID: <1388782820.12893.6.camel@powernoodle.corp.yahoo.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
X-Milter-Version: master.31+4-gbc07cd5+
X-CLX-ID: 782821010
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jan 2014 21:10:59 -0000

On Fri, 2014-01-03 at 20:45 +0000, Sean Bruno wrote:
> Author: sbruno
> Date: Fri Jan  3 20:45:56 2014
> New Revision: 260243
> URL: http://svnweb.freebsd.org/changeset/base/260243
> 
> Log:
>   Wrap this debug statement in debug defines.  Else, this driver
>   will refuse to load.

should have read "will refuse to load as a module"

link_elf_obj: symbol aacraid_get_fw_debug_buffer undefined
linker_load_file: Unsupported file type


sean


>   
>   MFC after:	2 weeks
>   Sponsored by:	Yahoo! Inc.
> 
> Modified:
>   head/sys/dev/aacraid/aacraid.c
> 
> Modified: head/sys/dev/aacraid/aacraid.c
> ==============================================================================
> --- head/sys/dev/aacraid/aacraid.c	Fri Jan  3 20:27:15 2014	(r260242)
> +++ head/sys/dev/aacraid/aacraid.c	Fri Jan  3 20:45:56 2014	(r260243)
> @@ -1728,7 +1728,9 @@ aac_check_firmware(struct aac_softc *sc)
>  		device_printf(sc->aac_dev, "Enable 64-bit array\n");
>  	}
>  
> +#ifdef AACRAID_DEBUG
>  	aacraid_get_fw_debug_buffer(sc);
> +#endif
>  	return (0);
>  }
>