From owner-cvs-src-old@FreeBSD.ORG Fri Jun 11 20:38:31 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B79A31065675 for ; Fri, 11 Jun 2010 20:38:31 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A5B688FC08 for ; Fri, 11 Jun 2010 20:38:31 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o5BKcVxc065211 for ; Fri, 11 Jun 2010 20:38:31 GMT (envelope-from tuexen@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o5BKcVTQ065210 for cvs-src-old@freebsd.org; Fri, 11 Jun 2010 20:38:31 GMT (envelope-from tuexen@repoman.freebsd.org) Message-Id: <201006112038.o5BKcVTQ065210@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to tuexen@repoman.freebsd.org using -f From: Michael Tuexen Date: Fri, 11 Jun 2010 20:38:20 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_8 Subject: cvs commit: src/sys/netinet sctp_pcb.c sctp_usrreq.c sctputil.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2010 20:38:31 -0000 tuexen 2010-06-11 20:38:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_8) sys/netinet sctp_pcb.c sctp_usrreq.c sctputil.c Log: SVN rev 209067 on 2010-06-11 20:38:20Z by tuexen MFC 209029 3 Fixes - a) There was a case where a ICMP message could cause us to return leaving a stuck lock on an stcb. b) The iterator needed some tweaks to fix its lock ordering. c) The ITERATOR_LOCK is no longer needed in the freeing of a stcb. Now that the timer based one is gone we don't have a multiple resume situation. Add to that that there was somewhere a path out of the freeing of an assoc that did NOT release the iterator_lock.. it was time to clean this old code up and in the process fix the lock bug. Approved by: re (bz) Revision Changes Path 1.85.2.12 +11 -39 src/sys/netinet/sctp_pcb.c 1.67.2.11 +3 -0 src/sys/netinet/sctp_usrreq.c 1.93.2.16 +14 -4 src/sys/netinet/sctputil.c