From nobody Wed Sep 10 19:49:09 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cMWV90tMSz66mgh; Wed, 10 Sep 2025 19:49:21 +0000 (UTC) (envelope-from phil@juniper.net) Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Sectigo RSA Organization Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cMWV85Jqpz3sgR; Wed, 10 Sep 2025 19:49:20 +0000 (UTC) (envelope-from phil@juniper.net) Authentication-Results: mx1.freebsd.org; none Received: from pps.filterd (m0108156.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58AGGROV011602; Wed, 10 Sep 2025 12:49:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=PPS1017; bh=oz vauQy9KLCfm/81GZiGH5wr3Kf7kvn7pcDVg9k4awE=; b=xR+yWtKijikmEM4fpw jJ6ib0r/ZhoSmDTj7XDZ0YcSUKbLjrjAVR3bI1uOIgsMrRc5EJqd4wDD7fsooDtd i3dPPM/SYC+2F1HnEAtvzrkcao6yzEWls7H3h4paV9AB/zA3m3F9zl2um0mJVKdq RRgaaZKFgC/mNdezfjyhBkIwQQlnwv8QyrZ8oGWcBJC2A9vNlsLCKqHhTUXt/ykh sVqh53EEkNE5twsi63hC9n45+TQtZAqXY/u+P4rKjslxVZbfSv1rSDuersJEbDjk I9Kd7EWG51VtQU9xK2jLykSXARjcVlY6XFz9p4UHi/l5JLm7+tIZsoAyOD++tkFR TGwA== Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11020138.outbound.protection.outlook.com [52.101.193.138]) by mx0a-00273201.pphosted.com (PPS) with ESMTPS id 4935rfhgs7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Sep 2025 12:49:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R7bOUwofbUzUjA5xPSWRlIk9jHNeRqiE0nKxfQ1FxVVtkRjdglXT29WKCYCvzM6Cz4zOl7A2mosG/Ifeod3Ta9nZ4P3FC1tdwo2CDxinPEQnGKLxuDiZXPL2RehrwgEXjwKJn0QHAhCMyX3eTqi0Uqy7CEmLWOVJLKmEVBXBi67+X5Fu9mmYDKXQzmUnS/hU7+71byGcu6MwRKoDlNV1enXbvoWvlp4pGye2lGUYRYBTDdi9wj8wJgOoTBIJmpbmHwKZJiR2aEkru3Hi5ZZO7g1vLkHslcJpWT7pth4UFV2AlTfvm3lM0LNkGrcnIqriRwu2nAexBLcNgMhT9CZs6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ozvauQy9KLCfm/81GZiGH5wr3Kf7kvn7pcDVg9k4awE=; b=LKPjRA30gzD5IQ5P5Mit84+Wi1vUmUWzfxgrXH6M12jv6HsJVygR3enmHGiebEkIRWo4pl9C0XxLPKH/5r6mHn36MPtgcX+Psj2CYBfMRgol+DSQDWKk0sB5fXuu6J/O2iqYMZiTgm6esyUNqSZ5JsonT52sp8zpIi5lye0Xm3hhIuA/jBOUYmkpCErDCrBiGCzwRT8JrlQf+fxvwbVf8jKeChpeWlwDYrFNm3XSDi5tWiVRj9jQlOOnnfixX1vl0QfapFA32/Uid8Xp6k8Y38fNaSR3pkOQdIPXkxS78ZEoBALHGYRwC7GIfDPATKe0muo7ybyzGYCrunYyUauphA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.15) smtp.rcpttodomain=gmail.com smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ozvauQy9KLCfm/81GZiGH5wr3Kf7kvn7pcDVg9k4awE=; b=DjlpdDJULBSKzi2PhSRAYg5yFlsZ17LEZnrVSmPHUpoVsSUSVgDxzqI9gJ0CVqOfLOdF0iUeyuJufLrSu1O2bZ7ORJEEOca4FVEy8om/lqpNXDGAN1kaWWmyZeIwU+PuwcQ8kO0/3L3b59OJX8VmcVVcyAvqR03BO4UNln0f784= Received: from BYAPR01CA0037.prod.exchangelabs.com (2603:10b6:a03:94::14) by SA3PR05MB9668.namprd05.prod.outlook.com (2603:10b6:806:313::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.19; Wed, 10 Sep 2025 19:49:14 +0000 Received: from CO1PEPF000066E7.namprd05.prod.outlook.com (2603:10b6:a03:94:cafe::f3) by BYAPR01CA0037.outlook.office365.com (2603:10b6:a03:94::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9115.16 via Frontend Transport; Wed, 10 Sep 2025 19:49:02 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.239.15) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.15 as permitted sender) Received: from p-exchfe-eqx-02.jnpr.net (66.129.239.15) by CO1PEPF000066E7.mail.protection.outlook.com (10.167.249.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.13 via Frontend Transport; Wed, 10 Sep 2025 19:49:13 +0000 Received: from p-exchbe-eqx-01.jnpr.net (10.104.9.14) by p-exchfe-eqx-02.jnpr.net (10.104.9.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 10 Sep 2025 14:49:13 -0500 Received: from p-exchbe-eqx-01.jnpr.net (10.104.9.14) by p-exchbe-eqx-01.jnpr.net (10.104.9.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 10 Sep 2025 14:49:13 -0500 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-01.jnpr.net (10.104.9.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Wed, 10 Sep 2025 14:49:13 -0500 Received: from idleski.juniper.net (idleski.juniper.net [172.25.4.10]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 58AJnBjv004047; Wed, 10 Sep 2025 12:49:12 -0700 (envelope-from phil@juniper.net) Received: from [10.0.0.103] (localhost [127.0.0.1]) by idleski.juniper.net (8.18.1/8.18.1) with ESMTP id 58AJnx9c086480; Wed, 10 Sep 2025 15:50:00 -0400 (EDT) (envelope-from phil@juniper.net) From: Phil Shafer To: Konstantin Belousov CC: Ka Ho Ng , , , Subject: Re: git: 11ace56fa030 - main - contrib/libxo: fix API header files inclusions in C++ source files Date: Wed, 10 Sep 2025 15:49:09 -0400 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: References: <202509071842.587IgHbm001636@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066E7:EE_|SA3PR05MB9668:EE_ X-MS-Office365-Filtering-Correlation-Id: 07442abe-0cfe-435c-a898-08ddf0a31e89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vh+pJbfuFp7iFe+k7sY0l9sQHqBT/9sBrQH3qLwT77texwaOGpaZbiGJsMFs?= =?us-ascii?Q?9nOsgdDx25gC/yHwBwZvW+mm8xadFp/InJ4vvFnbsquFvb97HS7lbAtMgJLu?= =?us-ascii?Q?h1DOGD2StxL6DOl/1bka8pyJ+j8rEvbDx0hNkMRGdN89QqrYIDT6eZX3iQn9?= =?us-ascii?Q?pyP6yRb2k6W5lKcWHk6vKjzCqa8gzFjeT6v5fVktWXUGj+P3gD33exnLRkOp?= =?us-ascii?Q?3j7QDdLBu38WDmq/QjFGSnpm5lUyHRXKc4pmLc+8UFZIJY8JC/DFskBqi3y6?= =?us-ascii?Q?bd19qHgMXRAcxYbh+KDF1gdHSnL0v2o/i85dGsBFUDDI8wWHhkeoj6rU1a2t?= =?us-ascii?Q?WkV+szSX5eux1aTo0VLW81XpNaSO8FKjbBjkaWkXA7T80TuE2SQuQ681+Tmc?= =?us-ascii?Q?VwyRm+G+ezO+r/SIb+C9/InKoVf1T1rdp8ZC4LoAMJ5rfWKxiQ30Hx92pUm/?= =?us-ascii?Q?Bvmth1mJFuNnyw2MxYZ7vWF5hbE4VbUMr3lp2saq1pTxobHXnBbhO/zX3N7e?= =?us-ascii?Q?W7V3KKwlmQT7e4KeTKy0nHtT+jGhmnIZUKB9RSJZGFl9m08E92nYocwBME/r?= =?us-ascii?Q?gFrdVGrDARWnXK9nIhSsoNDgf0KfgQODbJCvsdk34BemmDh7+gdm/EoZUbl2?= =?us-ascii?Q?mkgVZiyysRiCkOsfMdke9mFONwYcb+aOUMqzvr8yIiXgL49qDDIGqYhtEIJi?= =?us-ascii?Q?c3qO+CL0JY7py4CjRKv4UtTMh45dLynsmv/V3CVkn3CNtJeGCndleiSDZOLs?= =?us-ascii?Q?dWUTqRLPNeQ6ocp9YBhQUQ4tl48blPfvsEMVrE21vIdYdiiDKj3pB0ZKzmm2?= =?us-ascii?Q?Zw1ZVzdJuoGe9fmWxgPsJmfygTX/AMh3PUxgMQO3XrHk7Hm+VHZecOGb2MKr?= =?us-ascii?Q?bKwQfhp15qlfl1PbfuQpFKaamhIxvkJujOVsfsC9MKcVl1KH+u26UB7Wqpy3?= =?us-ascii?Q?FX3OalEAA0YsaK1L8HVDZdQOr1AvzuoDtK99rDADoGn6RW2jBlUxxHcNmSN3?= =?us-ascii?Q?8PqBB48FtkbDinXTzXXklZ+Vi+OxQb305od9OdQOpX7gXz8gNzCwZXGf0XVX?= =?us-ascii?Q?3o4qpk3qrZCzZiurQDKgxUnMj9mScTP8fXcpNVosznI7ASua+zaV/fNPq/2V?= =?us-ascii?Q?smutgbEYf9dY10FLm9lzTR+uuHm/r1mDlLHNTZ2jYwXORoIxOLHFBLX3t7Ul?= =?us-ascii?Q?rtUeIJHcrVKEktXtSRNWhoc3w77PgFTsvFUXLIjxipZJH63ItFnLl8zi3uem?= =?us-ascii?Q?IbnLRyjMnsKUhl9WI3FQbhSRB7IS7wradodqDkPdYPwBKWn9sfI/xVIVeOQ+?= =?us-ascii?Q?25wzSNdGVhR+gwvj6AsEd4z5Bs4f48kw3yCtlQcl6f++zYLEGwZmq9Ar7TXD?= =?us-ascii?Q?WVMXH8UMciAovTtD0mGnH7rxYw5ezmDMQTc0MSUOMEZixI2AuO+i5IcCUaQS?= =?us-ascii?Q?y40trKUb73r5LawFwkg/rCITXIUrL9yHKkCh6k3ZVsSSGNznZioJ8vH7EkB7?= =?us-ascii?Q?2jdcgCfErIbbu/nDdlYP4tkCHpaodtNJik9k?= X-Forefront-Antispam-Report: CIP:66.129.239.15;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-02.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2025 19:49:13.8582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07442abe-0cfe-435c-a898-08ddf0a31e89 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.239.15];Helo=[p-exchfe-eqx-02.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066E7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR05MB9668 X-Authority-Analysis: v=2.4 cv=H4Pbw/Yi c=1 sm=1 tr=0 ts=68c1d63f cx=c_pps a=wpg3e3TFAlO0qOiIlNsFBg==:117 a=YQU41r7WENJiSYrYYNJVsQ==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=h8e1o3o8w34MuCiiGQrqVE4VwXA=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=yJojWOMRYYMA:10 a=s63m1ICgrNkA:10 a=rhJc5-LppCAA:10 a=MHmaIDd8pHwpRYVouS8A:9 X-Proofpoint-ORIG-GUID: 5XLpMU68Gt1WqpXERSkrO189Qt6QMPic X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEwMDA3NCBTYWx0ZWRfX/VIIWts1vsyl k6JJgKY94b0foCuTMOqDKpo4huh+h5/zYVPPNzOyi9VUX/CsVpBj4AObjiw2OEZt4AAy+05hjWV D/uNATaHINND4JpTbUXJZ2q+1vqD65dxMggrtHKrt95yn8NSDGoPkC/2K1wUUwHb2lnERji5Qye tAyaGdjW2SyDueBRFhnZXxzIdrcyeUlRySvZhL3nisOTq1FtuYNz0Vw5CrMU5csy5FNNyEbi3P5 z6jYA/tdFHn5D5pL+kDmZby2JVjBZciTTeRwx/vbZIW23lK+HGs1kgQTovb4t/IseCkD1xfvi0b TxdvOil725h4jtr8BCwv//AfdKK4glivjY+7XDd73KDG/1NNaJagDaQa9zOdPi4wxys7ZorK/Up 4vPKRrNV X-Proofpoint-GUID: 5XLpMU68Gt1WqpXERSkrO189Qt6QMPic X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-10_04,2025-09-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 clxscore=1011 priorityscore=1501 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509100074 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:26211, ipnet:208.84.65.0/24, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cMWV85Jqpz3sgR It's not freebsd-specific, but __BEGIN_DECLS isn't freebsd only. If it's= reasonably portable, it makes sense to use it. I see it in macOS, glibc= , and linux (at least some of dists). Thanks, Phil On 10 Sep 2025, at 0:31, Konstantin Belousov wrote: > Would it be better to use __BEGIN_DECLS? I am not completely sure due t= o > > contrib/, but libxo is FreeBSD-specific enough already.