From owner-svn-src-head@freebsd.org Fri Oct 27 06:34:01 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 664A8E5D57F; Fri, 27 Oct 2017 06:34:01 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EA5CE7DAC5; Fri, 27 Oct 2017 06:34:00 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wm0-x235.google.com with SMTP id p75so1433275wmg.3; Thu, 26 Oct 2017 23:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pyi22pvWZxbj87Xzpa/v84QOKxQooDYId0CSXH1Ctis=; b=Y2/NVtMA0SbygiXYxIZxpWJ6vLIp0d8RaP8JfCBf2sJ4kLtHvTJSyjWjoDYshZ76Cj W7TxbFnow0oNzIGtU/+nSytrrS8avgvVcgVOLplAm7urJjzxTDs1JDAZLKF1n15dD3YG 0P69+tq7Us0TbugxXG6Cz9B5sgAu+v6AlWAWi3l/VXeQilcQILG6e6MKIn09Y+4AXUA+ oMbQuwrOjv6NK1pDHCisA5aclJACReUxTOqVn0nGh39nwORVYHU4oisi4tYdSTeqaBed ScOKDQdJF/QUhtyJ4Ja+PKXfSxAb07AyV3+8gJXPHRtoWDb1bmTYvYR0bxNI/C1qXjd2 GHPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pyi22pvWZxbj87Xzpa/v84QOKxQooDYId0CSXH1Ctis=; b=fQbAsIY7QElKL2hxX/VDv+CcblG0KYJ/hNPMZiJ/ImHevSMWuJvtIdPoC5DB+oNm8u HxQ3D9sJaqpP0yfsEFAyt/SNzFMXoYa3Cu5u7m8DzRJNgmZUnJXhZiKMcoQW4o6t8Uby F8jN2+KrySTDhBsllIocQ12SrmtsRj8Dyl4uVcg6rPsl1fr6Xjvy+oxp1VBYnNMIv8PG WwjddsGZfOT6gWvfg/+PKWBGEE2xRRbCcOHRPAEd6pWUUXXnQTIBWztj8rkbckfL4FzP 6+0VQAVeCOst0KquETqZeMF+3ZwXCr0vKAAPEfSKTMuMDrHVZvTHtdu4o9y+xgmn6qOX IUbg== X-Gm-Message-State: AMCzsaVj/jIgXRbhaOwXzV2d3NblbPfaIetpOi13zaNUd/9cW/3zz7CG 2NDBjTD4SSQaL8s1kp67XjT5lPQvvaw= X-Google-Smtp-Source: ABhQp+R9278ZQsfkQP2RQWpRIhr4OLOqsPFPbCfqnYBOTIYlmpO4gf9iMArzqUtpKNB58Z5brQ7Nqw== X-Received: by 10.80.133.203 with SMTP id q11mr30158373edh.50.1509086038997; Thu, 26 Oct 2017 23:33:58 -0700 (PDT) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id p45sm5245888edc.30.2017.10.26.23.33.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Oct 2017 23:33:58 -0700 (PDT) From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: mmel@freebsd.org Subject: Re: svn commit: r324938 - head/contrib/jemalloc/include/jemalloc/internal To: Dimitry Andric , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201710232131.v9NLV4Rb068825@repo.freebsd.org> Message-ID: <38db6f4e-72b8-6ffd-4529-f15ca32bad54@freebsd.org> Date: Fri, 27 Oct 2017 08:33:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201710232131.v9NLV4Rb068825@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 06:34:01 -0000 On 23.10.2017 23:31, Dimitry Andric wrote: > Author: dim > Date: Mon Oct 23 21:31:04 2017 > New Revision: 324938 > URL: https://svnweb.freebsd.org/changeset/base/324938 > > Log: > After jemalloc was updated to version 5.0.0 in r319971, i386 executables > linked with AddressSanitizer (even those linked on earlier versions of > FreeBSD, or with external versions of clang) started failing with errors > similar to: > > ==14688==AddressSanitizer CHECK failed: > /usr/src/contrib/compiler-rt/lib/asan/asan_poisoning.cc:36 > "((AddrIsAlignedByGranularity(addr))) != (0)" (0x0, 0x0) > > This is because AddressSanitizer expects all the TLS data in the program > to be aligned to at least 8 bytes. > > Before the jemalloc 5.0.0 update, all the TLS data in the i386 version > of libc.so added up to 80 bytes (a multiple of 8), but 5.0.0 made this > grow to 2404 bytes (not a multiple of 8). This is due to added caching > data in jemalloc's internal struct tsd_s. > > To fix AddressSanitizer, ensure this struct is aligned to at least 16 > bytes, which can be done unconditionally for all architectures. (An > earlier version of the fix aligned the struct to 8 bytes, but only for > ILP32 architectures. This was deemed unnecessarily complicated.) > > PR: 221337 > X-MFC-With: r319971 > This causes a regression on armv7 for /rescue/sh. At least malloc_slow is != 0, but I don't known what's exactly happen. Any idea? ------------------------------------------------------------------- /usr/local/bin/gdb801 --args /usr/obj/usr/src/rescue/rescue/rescue sh GNU gdb (GDB) 8.0.1 [GDB v8.0.1 for FreeBSD] Reading symbols from /usr/obj/usr/src/rescue/rescue/rescue...done. (gdb) r Starting program: /usr/obj/usr/src/rescue/rescue/rescue sh : /usr/src/contrib/jemalloc/include/jemalloc/internal/tsd.h:241: Failed assertion: "!malloc_slow && tsd_tcache_enabled_get(tsd) && tsd_reentrancy_level_get(tsd) == 0" Program received signal SIGABRT, Aborted. thr_kill () at thr_kill.S:3 3 RSYSCALL(thr_kill) (gdb) bt #0 thr_kill () at thr_kill.S:3 #1 0x00823ac8 in __raise (s=6) at /usr/src/lib/libc/gen/raise.c:52 #2 0x00823a4c in abort () at /usr/src/lib/libc/stdlib/abort.c:65 #3 0x007c49cc in tsd_assert_fast (tsd=0x20c82010) at /usr/src/contrib/jemalloc/include/jemalloc/internal/tsd.h:240 #4 0x007c3e3c in tsd_fast (tsd=0x20c82010) at /usr/src/contrib/jemalloc/include/jemalloc/internal/tsd.h:248 #5 0x007c4c40 in tsd_fetch_impl (init=true, minimal=false) at /usr/src/contrib/jemalloc/include/jemalloc/internal/tsd.h:266 #6 0x007c47e0 in tsd_fetch () at /usr/src/contrib/jemalloc/include/jemalloc/internal/tsd.h:290 #7 0x007c4774 in __je_malloc_tsd_boot0 () at jemalloc_tsd.c:256 #8 0x00821370 in malloc_init_hard () at jemalloc_jemalloc.c:1473 #9 0x00817d24 in malloc_init () at jemalloc_jemalloc.c:220 #10 0x00814dbc in imalloc (sopts=0xbfbfec70, dopts=0xbfbfec54) at jemalloc_jemalloc.c:1931 #11 0x00814ca8 in __malloc (size=12) at jemalloc_jemalloc.c:1981 #12 0x0019454c in callback_register (func=0x19b290 , arg=0x0) at /usr/src/sbin/ifconfig/ifconfig.c:705 #13 0x0019b274 in vlan_ctor () at /usr/src/sbin/ifconfig/ifvlan.c:227 #14 0x00008318 in handle_static_init (argc=, argv=, env=) at /usr/src/lib/csu/common/ignore_init.c:85 #15 __start (argc=2, argv=0xbfbfed00, env=0xbfbfed0c, ps_strings=, obj=0x0, cleanup=) at /usr/src/lib/csu/arm/crt1.c:108 #16 0x00008180 in ?? () Backtrace stopped: previous frame identical to this frame (corrupt stack?) (gdb) Quit > Modified: > head/contrib/jemalloc/include/jemalloc/internal/tsd.h > > Modified: head/contrib/jemalloc/include/jemalloc/internal/tsd.h > ============================================================================== > --- head/contrib/jemalloc/include/jemalloc/internal/tsd.h Mon Oct 23 20:50:08 2017 (r324937) > +++ head/contrib/jemalloc/include/jemalloc/internal/tsd.h Mon Oct 23 21:31:04 2017 (r324938) > @@ -120,7 +120,8 @@ struct tsd_s { > t use_a_getter_or_setter_instead_##n; > MALLOC_TSD > #undef O > -}; > +/* AddressSanitizer requires TLS data to be aligned to at least 8 bytes. */ > +} JEMALLOC_ALIGNED(16); > > /* > * Wrapper around tsd_t that makes it possible to avoid implicit conversion >