From owner-svn-src-stable@FreeBSD.ORG  Wed May  7 02:38:43 2014
Return-Path: <owner-svn-src-stable@FreeBSD.ORG>
Delivered-To: svn-src-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8EAA9D08;
 Wed,  7 May 2014 02:38:43 +0000 (UTC)
Received: from mail-oa0-x22c.google.com (mail-oa0-x22c.google.com
 [IPv6:2607:f8b0:4003:c02::22c])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2ABD41C0;
 Wed,  7 May 2014 02:38:43 +0000 (UTC)
Received: by mail-oa0-f44.google.com with SMTP id i11so442532oag.17
 for <multiple recipients>; Tue, 06 May 2014 19:38:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=9+gdkZvbzJUmk+fznxpnqMLAo3fdmO31dIRL0cfK3Qc=;
 b=NN1/KuFXsdWRINWyCFb1/fYitna23iy761WWZzGxyaolvkKdmtUdA14vbhsXHCAgoF
 j/rVowhzZIGLI+qcfX7skZnCHIZx6kAP/eLzwhO5+k0+udFZCf8MObDi8dUP5Po44xHC
 J8e6bN9ZY5vLIr6C5mHf//AzF7eG8LjhbhGtpaLKLAyX06RSOm/M7ia2yPLp9or11jx/
 N7PKUKSJJKXKUK6YzLWHAPs7Gs3xzc9b9s9nacc1QadMu55uyr+z6ZM5R7DijzU2Eujb
 RSLhZMA6B7E3PgmRImYmVYNECWBeMrOzRmyeQMbNK7RN0Zva8+QfZGDjdGm26/sevUkn
 iAGA==
MIME-Version: 1.0
X-Received: by 10.60.157.202 with SMTP id wo10mr43352733oeb.9.1399430322474;
 Tue, 06 May 2014 19:38:42 -0700 (PDT)
Received: by 10.76.23.130 with HTTP; Tue, 6 May 2014 19:38:42 -0700 (PDT)
In-Reply-To: <201405070213.s472Dtip073500@svn.freebsd.org>
References: <201405070213.s472Dtip073500@svn.freebsd.org>
Date: Tue, 6 May 2014 22:38:42 -0400
Message-ID: <CAFMmRNw5DvJvoxHdnLr4sZOGLnhK=W1oKDMtJS+Bp=VPsDx02g@mail.gmail.com>
Subject: Re: svn commit: r265478 - stable/9/sys/dev/cxgbe
From: Ryan Stone <rysto32@gmail.com>
To: Navdeep Parhar <np@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, svn-src-stable-9@freebsd.org
X-BeenThere: svn-src-stable@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for all the -stable branches of the src tree
 <svn-src-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-stable/>
List-Post: <mailto:svn-src-stable@freebsd.org>
List-Help: <mailto:svn-src-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-stable>,
 <mailto:svn-src-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 May 2014 02:38:43 -0000

On Tue, May 6, 2014 at 10:13 PM, Navdeep Parhar <np@freebsd.org> wrote:
> +       SYSCTL_ADD_PROC(ctx, children, OID_AUTO, "temperature", CTLTYPE_INT |
> +           CTLFLAG_RD, sc, 0, sysctl_temperature, "A",
> +           "chip temperature (in Celsius)");

I believe that this is incorrect.  "A" is used for strings (I guess it
stands for ASCII?).  I would suggest using "IK", which is an
indication that the return value is an integer in tenths of degrees
Kelvin.  sysctl(8) will handle this value specially and print it in
degrees C.

You can take a look at dev/coretemp, which uses this sysctl format.