From owner-freebsd-bugs@FreeBSD.ORG Mon Apr 21 09:40:01 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A792A106566C for ; Mon, 21 Apr 2008 09:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8304A8FC24 for ; Mon, 21 Apr 2008 09:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m3L9e1W0089327 for ; Mon, 21 Apr 2008 09:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m3L9e1b2089326; Mon, 21 Apr 2008 09:40:01 GMT (envelope-from gnats) Resent-Date: Mon, 21 Apr 2008 09:40:01 GMT Resent-Message-Id: <200804210940.m3L9e1b2089326@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ivan Voras Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AC76C1065672 for ; Mon, 21 Apr 2008 09:36:07 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 99C5D8FC1D for ; Mon, 21 Apr 2008 09:36:07 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3L9Zl27052864 for ; Mon, 21 Apr 2008 09:35:47 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m3L9ZlNF052863; Mon, 21 Apr 2008 09:35:47 GMT (envelope-from nobody) Message-Id: <200804210935.m3L9ZlNF052863@www.freebsd.org> Date: Mon, 21 Apr 2008 09:35:47 GMT From: Ivan Voras To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/122957: ath_hal is too verbose when booting X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Apr 2008 09:40:01 -0000 >Number: 122957 >Category: kern >Synopsis: ath_hal is too verbose when booting >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 21 09:40:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Ivan Voras >Release: 7.x >Organization: >Environment: FreeBSD 7.0-RELEASE >Description: ath_hal kernel module is too verbose when booting. It always prints its banner instead of only when in bootverbose mode. >How-To-Repeat: Boot any recent FreeBSD. Observe message: ath_hal: 0.9.20.3 (AR5210, AR5211, AR5212, RF5111, RF5112, RF2413, RF5413) Drivers shouldn't display their banners when the hardware they support isn't there. >Fix: See patch. Patch attached with submission follows: --- ath_old/ah_osdep.c 2008-04-18 11:22:53.000000000 +0200 +++ ath/ah_osdep.c 2008-04-18 11:23:48.000000000 +0200 @@ -411,13 +411,15 @@ switch (type) { case MOD_LOAD: - printf("ath_hal: %s (", ath_hal_version); - sep = ""; - for (i = 0; ath_hal_buildopts[i] != NULL; i++) { - printf("%s%s", sep, ath_hal_buildopts[i]); - sep = ", "; + if (bootverbose) { + printf("ath_hal: %s (", ath_hal_version); + sep = ""; + for (i = 0; ath_hal_buildopts[i] != NULL; i++) { + printf("%s%s", sep, ath_hal_buildopts[i]); + sep = ", "; + } + printf(")\n"); } - printf(")\n"); return 0; case MOD_UNLOAD: return 0; >Release-Note: >Audit-Trail: >Unformatted: