Date: Tue, 10 Apr 2012 13:29:33 GMT From: Shin-ichi Okano <s-okano@n08.itscom.net> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/166817: [PATCH] audio/sound-juicer suddenly exits Message-ID: <201204101329.q3ADTXOk055729@red.freebsd.org> Resent-Message-ID: <201204101330.q3ADU1L9062808@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166817 >Category: ports >Synopsis: [PATCH] audio/sound-juicer suddenly exits >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Apr 10 13:30:01 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Shin-ichi Okano >Release: 9-STABLE >Organization: >Environment: FreeBSD wombat.s-okano.n08.itscom.net 9.0-STABLE FreeBSD 9.0-STABLE #0 r233835: Tue Apr 3 20:57:43 JST 2012 s-okano@wombat.s-okano.n08.itscom.net:/usr/obj/usr/src/sys/WOMBAT amd64 >Description: sound-juicer suddenly exits when inserting the disc whose information is not registered in musicbrainz. This problem is caused by reference to unset variables. >How-To-Repeat: Launch sound-juicer and insert the disc whose information is not registered in musicbrainz yet. >Fix: This is already fixed in upstream. Applied the attached patch should fix this problem. (See http://mail.gnome.org/archives/commits-list/2011-May/msg06778.html) Patch attached with submission follows: --- src/sj-main.c.orig 2012-02-14 16:44:03.000000000 +0900 +++ src/sj-main.c 2012-02-14 16:46:41.000000000 +0900 @@ -410,9 +410,11 @@ g_return_val_if_fail (title != NULL, NULL); g_return_val_if_fail (artist != NULL, NULL); - infobar = gtk_info_bar_new_with_buttons (_("S_ubmit Album"), GTK_RESPONSE_OK, - GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL, - NULL); + infobar = gtk_info_bar_new (); + button = gtk_info_bar_add_button (GTK_INFO_BAR (infobar), + _("S_ubmit Album"), GTK_RESPONSE_OK); + gtk_info_bar_add_button (GTK_INFO_BAR (infobar), + GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL); /* Translators: title, artist */ primary_text = g_strdup_printf (_("Could not find %s by %s on MusicBrainz."), title, artist); >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204101329.q3ADTXOk055729>