From owner-cvs-src@FreeBSD.ORG Sun Jan 29 08:33:34 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CEF2C16A420; Sun, 29 Jan 2006 08:33:34 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8184C43D49; Sun, 29 Jan 2006 08:33:32 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.240] (ppp-71-139-114-10.dsl.snfc21.pacbell.net [71.139.114.10]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id k0T8XVD8025917 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 29 Jan 2006 00:33:31 -0800 Message-ID: <43DC7DEB.7050200@root.org> Date: Sun, 29 Jan 2006 00:33:47 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Scott Long References: <20060129082512.6EBA116A477@hub.freebsd.org> In-Reply-To: <20060129082512.6EBA116A477@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_contig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2006 08:33:35 -0000 Scott Long wrote: > scottl 2006-01-29 08:24:54 UTC > > FreeBSD src repository > > Modified files: > sys/vm vm_contig.c > Log: > The change a few years ago of having contigmalloc start its scan at the top > of physical RAM instead of the bottom was a sound idea, but the implementation > left a lot to be desired. Scans would spend considerable time looking at > pages that are above of the address range given by the caller, and multiple > calls (like what happens in busdma) would spend more time on top of that > rescanning the same pages over and over. Interesting. > Index: src/sys/vm/vm_contig.c > diff -u src/sys/vm/vm_contig.c:1.47 src/sys/vm/vm_contig.c:1.48 > --- src/sys/vm/vm_contig.c:1.47 Thu Jan 26 05:51:26 2006 > +++ src/sys/vm/vm_contig.c Sun Jan 29 08:24:54 2006 > @@ -387,7 +387,9 @@ > vm_offset_t size; > vm_paddr_t phys; > vm_page_t pga = vm_page_array; > - int i, pass, pqtype, start; > + static vm_pindex_t np = 0; > + static vm_pindex_t start = 0; > + int i, pass, pqtype; What lock protects access to these static variables? -- Nate