From owner-freebsd-net  Tue Jul 11 16:46:40 2000
Delivered-To: freebsd-net@freebsd.org
Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8EB1837B786; Tue, 11 Jul 2000 16:46:37 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.3/8.9.2) id QAA41027;
	Tue, 11 Jul 2000 16:46:03 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <200007112346.QAA41027@bubba.whistle.com>
Subject: Re: ether_ifattach()/ether_ifdetach() patch
In-Reply-To: <396BA6D8.15FB7483@elischer.org> from Julian Elischer at "Jul 11, 2000 03:59:36 pm"
To: julian@elischer.org (Julian Elischer)
Date: Tue, 11 Jul 2000 16:46:03 -0700 (PDT)
Cc: freebsd-net@freebsd.org, csg@waterspout.com, ache@freebsd.org,
	wpaul@freebsd.org, imp@village.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

Julian Elischer writes:
> > To any interested parties, here is a patch to review.
> > 
> > This changes all ethernet drivers to only call ether_ifattach()
> > and ether_ifdetach(), consolidating some common actions, namely,
> > calls to if_attach(), bpfattach(), ng_ether_attach(), if_detach(),
> > bpfdetach(), and ng_ether_detach().
> > 
> > This also fixes the problem where detaching an ethernet interface
> > previously used for ng_ether(4) would panic (which resulted from
> > fixing the build to not require 'device ether' (which resulted
> > from making ng_ether(4) a loadable KLD)).
> > 
> >   ftp://ftp.whistle.com/pub/archie/misc/ETHERATTACH.patch.1
> 
> The constant 1 (2nd argument to ether_attach) should be
> defined as something meaningful in the ethernet include file.
> e.g. USE_BPF vs NO_BPF

Thanks for the comment.. here's a revised version:

  ftp://ftp.whistle.com/pub/archie/misc/ETHERATTACH.patch.2

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message