Date: Sun, 17 Mar 2019 21:36:45 +0000 From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 236438] [PATCH] x11-fm/thunar: add debug option Message-ID: <bug-236438-28711-HogdD79SKr@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-236438-28711@https.bugs.freebsd.org/bugzilla/> References: <bug-236438-28711@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236438 Guido Falsi <madpilot@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open CC| |madpilot@FreeBSD.org --- Comment #2 from Guido Falsi <madpilot@FreeBSD.org> --- Hi, Thanks for the patch, I had a look. While I do agree with adding DEBUG supp= ort, I think it should be done the "proper" way. In the ports tree there is support for the "WITH_DEBUG" flag, which automatically disables optimizations, adds the -g flag and disables strippi= ng of binaries(or at least tries to). If a port needs further flags they should be linked to this flag. I have also discovered that DEBUG options are not a good idea [1] So I'd rework this patch to not add a DEBUG option to the port but use the WITH_DEBUG (which is also triggere by WITH_DEBUG_PORTS) flag to check if ex= trra options should be enabled. I'd try to avoid a DEBUG option. Adding WITH_DEBUG_PORTS to make.conf is qu= ite easy. [1] https://reviews.freebsd.org/D15773 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236438-28711-HogdD79SKr>