From owner-p4-projects@FreeBSD.ORG  Wed Aug  1 22:20:31 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9AA3C16A469; Wed,  1 Aug 2007 22:20:31 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 53C8316A418
	for <perforce@FreeBSD.org>; Wed,  1 Aug 2007 22:20:31 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 41D6013C46C
	for <perforce@FreeBSD.org>; Wed,  1 Aug 2007 22:20:31 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l71MKVRB088477
	for <perforce@FreeBSD.org>; Wed, 1 Aug 2007 22:20:31 GMT
	(envelope-from cnst@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l71MKVCa088474
	for perforce@freebsd.org; Wed, 1 Aug 2007 22:20:31 GMT
	(envelope-from cnst@FreeBSD.org)
Date: Wed, 1 Aug 2007 22:20:31 GMT
Message-Id: <200708012220.l71MKVCa088474@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	cnst@FreeBSD.org using -f
From: "Constantine A. Murenin" <cnst@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 124494 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2007 22:20:31 -0000

http://perforce.freebsd.org/chv.cgi?CH=124494

Change 124494 by cnst@dale on 2007/08/01 22:19:48

	better error handling, although lm_detach() always returns 0,
	so this doesn't matter that much

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78_isa.c#4 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78_isa.c#4 (text+ko) ====

@@ -1,4 +1,4 @@
-/*	$P4: //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78_isa.c#3 $	*/
+/*	$P4: //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78_isa.c#4 $	*/
 /*	$FreeBSD$	*/
 /*	$OpenBSD: lm78_isa.c,v 1.2 2007/07/01 21:48:57 cnst Exp $	*/
 
@@ -232,10 +232,12 @@
 
 	/* Bus-independent detachment */
 	error = lm_detach(&sc->sc_lmsc);
+	if (error)
+		return (error);
 
 	bus_space_unmap(sc->sc_iot, sc->sc_ioh, 8);
 
-	return (error);
+	return (0);
 }
 
 u_int8_t