From owner-cvs-src@FreeBSD.ORG Sat Nov 19 20:48:55 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1374616A41F; Sat, 19 Nov 2005 20:48:55 +0000 (GMT) (envelope-from damien.bergamini@free.fr) Received: from smtp4-g19.free.fr (smtp4-g19.free.fr [212.27.42.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F68C43D6B; Sat, 19 Nov 2005 20:48:54 +0000 (GMT) (envelope-from damien.bergamini@free.fr) Received: from COMETE (pas38-1-82-67-68-158.fbx.proxad.net [82.67.68.158]) by smtp4-g19.free.fr (Postfix) with SMTP id 85C003FF93; Sat, 19 Nov 2005 21:48:53 +0100 (CET) Message-ID: <00ca01c5ed4a$86b0e570$0300a8c0@COMETE> From: "Damien Bergamini" To: "Nate Lawson" References: <20051119165547.0A4BD16A43D@hub.freebsd.org> <437F82A1.6080504@root.org> Date: Sat, 19 Nov 2005 21:47:58 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2670 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2670 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/iwi Makefile src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2005 20:48:55 -0000 | I'm a little concerned about this change. The notes claim the firmware | is loaded after a resume from the filesystem as well as at | initialization time. So your driver is then assuming the ATA driver is | fully reinitialized before your driver's resume method can be called. | You can't assume that since it's not a child device of ATA. Wouldn't the call to VOP_READ block until "/" is recovered in that case ? Or is it possible to delay the call to if_init until "/" is ready ? I know OpenBSD and NetBSD have mountroot hooks but I'm anaware of such a thing in FreeBSD. I've never been able to resume from any suspend mode on my laptop so I can't test this right now. | Also, I'm concerned about the unnecessary use of caddr_t (which I don't | think will work on PAE or 64 bit systems). | | -- | Nate I'll convert them to void* then, though I don't see why it hurts. Damien