From owner-cvs-src@FreeBSD.ORG Fri Apr 25 12:59:37 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14D3537B401; Fri, 25 Apr 2003 12:59:36 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0485B43FB1; Fri, 25 Apr 2003 12:59:36 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h3PJxZ0U075362; Fri, 25 Apr 2003 12:59:35 -0700 (PDT) (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h3PJxZhZ075361; Fri, 25 Apr 2003 12:59:35 -0700 (PDT) Message-Id: <200304251959.h3PJxZhZ075361@repoman.freebsd.org> From: John Baldwin Date: Fri, 25 Apr 2003 12:59:35 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_ktrace.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2003 19:59:37 -0000 jhb 2003/04/25 12:59:35 PDT FreeBSD src repository Modified files: sys/kern kern_ktrace.c Log: - Push down Giant around vnode operations in ktrace(). - Mark the ktrace() and utrace() syscalls as being MP safe. - Validate the facs argument to ktrace() prior to doing any vnode operations or acquiring any locks. - Share lock the proctree lock over the entire section that calls ktrsetchildren() and ktrops(). We already did this for process groups. Doing it for the process case closes a small race where a process might go away after we look it up. As a result of this, ktrstchildren() now just asserts that the proctree lock is locked rather than acquiring the lock itself. - Add some missing comments to #else and #endif. Revision Changes Path 1.84 +39 -22 src/sys/kern/kern_ktrace.c