From owner-cvs-src@FreeBSD.ORG Fri Dec 15 00:10:23 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BC98916A4A0; Fri, 15 Dec 2006 00:10:23 +0000 (UTC) (envelope-from davidch@broadcom.com) Received: from mms2.broadcom.com (mms2.broadcom.com [216.31.210.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2355A43E54; Fri, 15 Dec 2006 00:00:49 +0000 (GMT) (envelope-from davidch@broadcom.com) Received: from 10.10.64.154 by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.0)); Thu, 14 Dec 2006 16:02:12 -0800 X-Server-Uuid: 05DA3F36-9AA8-4766-A7E5-53B43A7C42E6 Received: by mail-irva-10.broadcom.com (Postfix, from userid 47) id 5CB962B0; Thu, 14 Dec 2006 16:02:12 -0800 (PST) Received: from mail-irva-8.broadcom.com (mail-irva-8 [10.10.64.221]) by mail-irva-10.broadcom.com (Postfix) with ESMTP id ED7C72AF; Thu, 14 Dec 2006 16:02:11 -0800 (PST) Received: from mail-irva-12.broadcom.com (mail-irva-12.broadcom.com [10.10.64.146]) by mail-irva-8.broadcom.com (MOS 3.7.5a-GA) with ESMTP id EQA22472; Thu, 14 Dec 2006 16:02:10 -0800 (PST) Received: from NT-IRVA-0750.brcm.ad.broadcom.com (nt-irva-0750 [10.8.194.64]) by mail-irva-12.broadcom.com (Postfix) with ESMTP id 2AD9069CA8; Thu, 14 Dec 2006 16:02:10 -0800 (PST) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Date: Thu, 14 Dec 2006 16:01:47 -0800 Message-ID: <09BFF2FA5EAB4A45B6655E151BBDD903029CEDDE@NT-IRVA-0750.brcm.ad.broadcom.com> In-Reply-To: <200612142310.kBENADQO042110@repoman.freebsd.org> Thread-Topic: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h Thread-Index: Accf1m+6zGZ6ihKkQVqvYVIOxj3TlQABAnuw From: "David Christensen" To: "John Polstra" , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-WSS-ID: 699F398E2EK3674278-01-01 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Cc: Subject: RE: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2006 00:10:23 -0000 John, MSI capabilities registers are present on virtually all "bge" controllers but many of the "older" controllers don't correctly support MSI due to a chip errata that prevents MSI interrupts from actually being disabled during an ISR. Check the Linux code for the test used in tg3_open() which determines which controllers can actually use MSI correctly. =20 Even with the bug the older controllers will appear to work correctly on a heavily loaded system for short periods of time (sometimes even days) but they will eventually fail. Dave > -----Original Message----- > From: owner-src-committers@FreeBSD.org=20 > [mailto:owner-src-committers@FreeBSD.org] On Behalf Of John Polstra > Sent: Thursday, December 14, 2006 3:10 PM > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org;=20 > cvs-all@FreeBSD.org > Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h >=20 > jdp 2006-12-14 23:10:13 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/bge if_bge.c if_bgereg.h=20 > Log: > Add MSI support to the bge driver. I tested this on a Dell SC1435 > running an i386 kernel, and it worked fine. > =20 > Revision Changes Path > 1.164 +18 -4 src/sys/dev/bge/if_bge.c > 1.62 +1 -0 src/sys/dev/bge/if_bgereg.h >=20 >=20