From owner-freebsd-current@FreeBSD.ORG Thu Sep 20 23:12:17 2007 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7EB0116A474 for ; Thu, 20 Sep 2007 23:12:17 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id 27CDB13C494 for ; Thu, 20 Sep 2007 23:12:16 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 13894 invoked by uid 399); 20 Sep 2007 23:12:16 -0000 Received: from localhost (HELO slave.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 20 Sep 2007 23:12:16 -0000 X-Originating-IP: 127.0.0.1 Date: Thu, 20 Sep 2007 16:12:13 -0700 (PDT) From: Doug Barton To: "Constantine A. Murenin" In-Reply-To: <46F1A96F.2040602@FreeBSD.org> Message-ID: References: <200709132302.l8DN2Tv5076033@repoman.freebsd.org> <46E9FC0C.70607@FreeBSD.org> <46F1A96F.2040602@FreeBSD.org> X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Alexander Leidinger , Shteryana Shopova , freebsd-current@FreeBSD.org Subject: Re: GSoC2007: cnst-sensors.2007-09-13.patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2007 23:12:17 -0000 On Wed, 19 Sep 2007, Constantine A. Murenin wrote: > Thanks for testing! Glad to help. In case it's interesting, I was doing the xorg update with portmaster last night and I got several "PROCHOT asserted" messages on my console at different times. I'm assuming that's expected behavior, just curious if it's something bad, as in when that happens it's time to turn off the laptop? (I didn't seem them when the happened, they were there when I got back to check on the compiling.) >> Two small comments about the rc.d stuff. First, the empty _flags variable >> in defaults/rc.conf should be commented out. Second, the rc.d > > How so? I don't see any other empty _flags variables in defaults/rc.conf > being commented out. Well you missed named_flags. :) But seriously, I didn't realize that things had gotten quite so out of hand with that ... never mind then. >> script needs the shutdown KEYWORD. > > Similarly, I don't see why this is needed -- it was not used by the scripts > on which this script was based on Which scripts? I realize that a distressingly large number of scripts that start services don't have this keyword, but they should. I'll work on a patch for that. At the same time, we don't want to add any new scripts that make the same mistake. > Reading through rc(8) doesn't seem to suggest that this keyword would > actually be applicable here. As far as I can tell, you're starting a daemon, which means that it should be cleanly shut down when the system exits. Doug -- This .signature sanitized for your protection