From owner-svn-src-all@FreeBSD.ORG Wed Oct 13 17:13:43 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 70E121065670; Wed, 13 Oct 2010 17:13:43 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 5F91A8FC0C; Wed, 13 Oct 2010 17:13:43 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o9DHDhUS094304; Wed, 13 Oct 2010 17:13:43 GMT (envelope-from rpaulo@svn.freebsd.org) Received: (from rpaulo@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o9DHDhgW094301; Wed, 13 Oct 2010 17:13:43 GMT (envelope-from rpaulo@svn.freebsd.org) Message-Id: <201010131713.o9DHDhgW094301@svn.freebsd.org> From: Rui Paulo Date: Wed, 13 Oct 2010 17:13:43 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r213791 - head/sys/cddl/compat/opensolaris/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2010 17:13:43 -0000 Author: rpaulo Date: Wed Oct 13 17:13:43 2010 New Revision: 213791 URL: http://svn.freebsd.org/changeset/base/213791 Log: Pass a format string to panic() and to taskqueue_start_threads(). Found with: clang Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c head/sys/cddl/compat/opensolaris/kern/opensolaris_taskq.c Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c ============================================================================== --- head/sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c Wed Oct 13 17:12:23 2010 (r213790) +++ head/sys/cddl/compat/opensolaris/kern/opensolaris_cmn_err.c Wed Oct 13 17:13:43 2010 (r213791) @@ -48,7 +48,7 @@ vcmn_err(int ce, const char *fmt, va_lis panic("Solaris: unknown severity level"); } if (ce == CE_PANIC) - panic(buf); + panic("%s", buf); if (ce != CE_IGNORE) vprintf(buf, adx); } Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_taskq.c ============================================================================== --- head/sys/cddl/compat/opensolaris/kern/opensolaris_taskq.c Wed Oct 13 17:12:23 2010 (r213790) +++ head/sys/cddl/compat/opensolaris/kern/opensolaris_taskq.c Wed Oct 13 17:13:43 2010 (r213791) @@ -73,7 +73,7 @@ taskq_create(const char *name, int nthre tq = kmem_alloc(sizeof(*tq), KM_SLEEP); tq->tq_queue = taskqueue_create(name, M_WAITOK, taskqueue_thread_enqueue, &tq->tq_queue); - (void) taskqueue_start_threads(&tq->tq_queue, nthreads, pri, name); + (void) taskqueue_start_threads(&tq->tq_queue, nthreads, pri, "%s", name); return ((taskq_t *)tq); }