From owner-svn-src-all@FreeBSD.ORG Wed Oct 15 04:14:24 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 189B68D0; Wed, 15 Oct 2014 04:14:24 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 561EC7C5; Wed, 15 Oct 2014 04:14:22 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s9F4EJ5t077519 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 15 Oct 2014 08:14:19 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s9F4EJpV077518; Wed, 15 Oct 2014 08:14:19 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 15 Oct 2014 08:14:19 +0400 From: Gleb Smirnoff To: Ed Maste Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys Message-ID: <20141015041418.GE73266@FreeBSD.org> References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <20141015030455.GC73266@FreeBSD.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= , "George V. Neville-Neil" , svn-src-all , src-committers , svn-src-head X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Oct 2014 04:14:24 -0000 On Tue, Oct 14, 2014 at 11:38:23PM -0400, Ed Maste wrote: E> On 14 October 2014 23:04, Gleb Smirnoff wrote: E> > E> > Look at results at the end of email. Guess what -j and -m mean. I E> > want either proving me doing the test wrong, or backing the change E> > out ASAP. E> E> It looks like there is indeed an error in the test: E> E> > h = murmur3_aligned_32((uint32_t *)&key[i], E> > sizeof(struct pf_state_key_cmp)/sizeof(uint32_t), E> E> murmur3's size argument is bytes, not uint32_ts, so the test is only E> hashing the first 1/4 of the keys. Thanks a lot, Ed. I rerun the tests. Results are fine. Distribution is equal (plots attached). Murmur is 9% +/- 1.5% faster. Sorry for noise. x jenkins-time + murmur-time +------------------------------------------------------------------------------+ | ++ x | | ++ xx | |+ +++ xx | |+++++ + + xx x x x x x| | |_A_| |_____M______A_____________| | +------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 12 8147243 8851519 8173132 8296753.8 235815.07 + 15 7502767 7655925 7547376 7551089.5 39524.149 Difference at 95.0% confidence -745664 +/- 127010 -8.98742% +/- 1.53084% (Student's t, pooled s = 159194) -- Totus tuus, Glebius.