From owner-freebsd-bugs@FreeBSD.ORG  Mon Aug  1 12:30:11 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6ACC4106566B
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  1 Aug 2011 12:30:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 234498FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  1 Aug 2011 12:30:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p71CUA8c092708
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 1 Aug 2011 12:30:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p71CUA4V092700;
	Mon, 1 Aug 2011 12:30:10 GMT (envelope-from gnats)
Resent-Date: Mon, 1 Aug 2011 12:30:10 GMT
Resent-Message-Id: <201108011230.p71CUA4V092700@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Svatopluk Kraus <onwahe@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4728C106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  1 Aug 2011 12:28:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 374F08FC15
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  1 Aug 2011 12:28:07 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p71CS7A4028449
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 1 Aug 2011 12:28:07 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p71CS6n3028448;
	Mon, 1 Aug 2011 12:28:06 GMT (envelope-from nobody)
Message-Id: <201108011228.p71CS6n3028448@red.freebsd.org>
Date: Mon, 1 Aug 2011 12:28:06 GMT
From: Svatopluk Kraus <onwahe@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/159353: [patch] conditional call of ifa_del_loopback_route() 
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Aug 2011 12:30:11 -0000


>Number:         159353
>Category:       kern
>Synopsis:       [patch] conditional call of ifa_del_loopback_route()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 01 12:30:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Svatopluk Kraus
>Release:        current
>Organization:
>Environment:
>Description:
ifa_del_loopback_route() is called even if IFA_RT_SELF is not set. It is not consistent and annoying message can be printed.
>How-To-Repeat:

>Fix:
Index: sys/netinet/raw_ip.c
===================================================================
--- sys/netinet/raw_ip.c	(revision 224572)
+++ sys/netinet/raw_ip.c	(working copy)
@@ -761,9 +761,11 @@
 		    || (ifp->if_flags & IFF_POINTOPOINT))
 			flags |= RTF_HOST;

+		if (ia->ia_flags & IFA_RTSELF) {
 		err = ifa_del_loopback_route((struct ifaddr *)ia, sa);
 		if (err == 0)
 			ia->ia_flags &= ~IFA_RTSELF;
+		}

 		err = rtinit(&ia->ia_ifa, RTM_ADD, flags);
 		if (err == 0)


>Release-Note:
>Audit-Trail:
>Unformatted: