From owner-freebsd-current@FreeBSD.ORG Fri Dec 4 22:48:15 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C50BF106568B for ; Fri, 4 Dec 2009 22:48:15 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (adsl-63-193-123-122.dsl.snfc21.pacbell.net [63.193.123.122]) by mx1.freebsd.org (Postfix) with ESMTP id 8A6D98FC0C for ; Fri, 4 Dec 2009 22:48:15 +0000 (UTC) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.14.3/8.14.3) with ESMTP id nB4MmFjK010464; Fri, 4 Dec 2009 14:48:15 -0800 (PST) (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.14.3/8.14.3/Submit) id nB4MmFNA010463; Fri, 4 Dec 2009 14:48:15 -0800 (PST) (envelope-from david) Date: Fri, 4 Dec 2009 14:48:15 -0800 From: David Wolfskill To: Luigi Rizzo Message-ID: <20091204224815.GF1130@albert.catwhisker.org> Mail-Followup-To: David Wolfskill , Luigi Rizzo , current@freebsd.org References: <20091204190438.GD1130@albert.catwhisker.org> <20091204221029.GA17787@onelab2.iet.unipi.it> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Y1L3PTX8QE8cb2T+" Content-Disposition: inline In-Reply-To: <20091204221029.GA17787@onelab2.iet.unipi.it> User-Agent: Mutt/1.4.2.3i Cc: current@freebsd.org Subject: Re: sys/netinet/ipfw/ip_fw2.c:2600: error: 'fw_one_pass' undeclared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2009 22:48:15 -0000 --Y1L3PTX8QE8cb2T+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 04, 2009 at 11:10:29PM +0100, Luigi Rizzo wrote: > On Fri, Dec 04, 2009 at 11:04:38AM -0800, David Wolfskill wrote: > > Running > >=20 > > FreeBSD d254.dwolf.juniper.net. 9.0-CURRENT FreeBSD 9.0-CURRENT #1 r200= 055: Thu Dec 3 17:04:59 PST 2009 root@d254.dwolf.juniper.net.:/common/= S4/obj/usr/src/sys/CANARY i386 > >=20 > > Sources updated to r200098; kernel build fails: >=20 > hmmm, i just completed a build with r200098 > though without vnet enabled, which may be the difference ? Oh, yeah -- I forgot that I tweaked the kernel to supoort vimage for Julian's demo last month. :-} And FWIW, my "build machine" -- which uses neither ipfw nor vimage -- built (and booted and smoke-tested) Just Fine. The laptop gets a bit more of a workout. (Especially since it can be connected to untrusted networks -- yeah, I use IPFW on the laptop.) :-} And there's a reason its kernel config is called "CANARY." :-} > Can you replace line p_fw2.c 2060 with > - if (fw_one_pass) { > + if (V_fw_one_pass) { > and see if it fixes the problem ? Reality check: that was ip_fw2.c:2582, yeah? Ref.: =2E.. 2572 mtag =3D m_tag_find(m, PACKET_TAG_DIVERT, NULL); 2573 if (args->rule) { 2574 /* 2575 * Packet has already been tagged. Look for the nex= t rule 2576 * to restart processing. Make sure that args->rule= still 2577 * exists and not changed. 2578 * If fw_one_pass !=3D 0 then just accept it. 2579 * XXX should not happen here, but optimized out in 2580 * the caller. 2581 */ 2582 if (V_fw_one_pass) { 2583 IPFW_RUNLOCK(chain); 2584 return (IP_FW_PASS); 2585 } =2E.. Anyway: with that change, the compile worked OK; I'll send word once I reboot it and see if it "leaks magic smoke." :-} > ... Thanks! Peace, david --=20 David H. Wolfskill david@catwhisker.org Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --Y1L3PTX8QE8cb2T+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEARECAAYFAksZkawACgkQmprOCmdXAD1nxQCeLh/b94e76XctWfegqGtmWfNv J1oAn13NeE1BDv1G5ReSS3RVEfhycuDF =jCBD -----END PGP SIGNATURE----- --Y1L3PTX8QE8cb2T+--