From owner-svn-src-all@FreeBSD.ORG Thu Aug 2 21:51:45 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id 7C1BA1065676; Thu, 2 Aug 2012 21:51:45 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 4B3B1152F9E; Thu, 2 Aug 2012 21:51:37 +0000 (UTC) Message-ID: <501AF66A.8020804@FreeBSD.org> Date: Thu, 02 Aug 2012 14:51:38 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Maksim Yevmenkin References: <201207191536.q6JFabOR094467@svn.freebsd.org> <20120803.055554.1380323232583218022.hrs@allbsd.org> In-Reply-To: X-Enigmail-Version: 1.4.3 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Hiroki Sato , src-committers@freebsd.org Subject: Re: svn commit: r238622 - head/etc/rc.d X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2012 21:51:45 -0000 On 8/2/2012 2:25 PM, Maksim Yevmenkin wrote: > On Thu, Aug 2, 2012 at 1:55 PM, Hiroki Sato wrote: > >> Just curious, why ip6addrctl_enable=NO is not enough here? Because the behavior of the script for =NO is to prefer v4. >> I would >> like to eliminate yes/no/none keywords in $ip6addrctl_policy because >> such keywords are vague. If we need the empty rule for some reason, >> "empty" would be a better name for the policy, I think. Personally I think that the established meanings of "yes" and "no" are well understood, but I wouldn't object to emitting a warning for them to help the user make a more explicit selection. While we're at it, the way that the current script replicates the test for checkyesno in case is bogus, and should be changed. I had fixed this in the change set that you(hrs) backed out. To stick with the structure of the current script, something like this would work: http://people.freebsd.org/~dougb/ip6addrctl.diff That also brings in the warning described above. > i just wanted to make sure that there is a way to absolutely make sure > that there is no default address selection policy installed. the wide > know rule 9 of rfc 3484 is really messing things up for dns-style load > balancing. even when ipv6 is not used. Maksim, can you say more about this? Or point me to a reference that has the discussion? > personally, i don't think that > "none" is unreasonable word for "ip6addrctl_policy", but i don't feel > particularly strongly about it. any name will do as long as original > functionality is preserved. I agree that "none" is reasonable, and is in line with other rc.d knobs. I would not object to "empty" being added as a synonym though. One request however, is this new knob documented in rc.conf.5? If not, can you do that please? :) Doug -- I am only one, but I am one. I cannot do everything, but I can do something. And I will not let what I cannot do interfere with what I can do. -- Edward Everett Hale, (1822 - 1909)