From owner-freebsd-bugs@FreeBSD.ORG  Mon Aug  8 13:20:13 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A2BB5106566C
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  8 Aug 2011 13:20:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6634D8FC15
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  8 Aug 2011 13:20:13 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p78DKDUK006669
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 8 Aug 2011 13:20:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p78DKDcI006668;
	Mon, 8 Aug 2011 13:20:13 GMT (envelope-from gnats)
Resent-Date: Mon, 8 Aug 2011 13:20:13 GMT
Resent-Message-Id: <201108081320.p78DKDcI006668@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Svatopluk Kraus <onwahe@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B1C48106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  8 Aug 2011 13:14:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A0C318FC0A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  8 Aug 2011 13:14:20 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p78DEKO6011641
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 8 Aug 2011 13:14:20 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p78DEKK8011623;
	Mon, 8 Aug 2011 13:14:20 GMT (envelope-from nobody)
Message-Id: <201108081314.p78DEKK8011623@red.freebsd.org>
Date: Mon, 8 Aug 2011 13:14:20 GMT
From: Svatopluk Kraus <onwahe@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/159603: [patch] in_ifscrubprefix() - network route can be
	installed for interfaces marked down
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2011 13:20:13 -0000


>Number:         159603
>Category:       kern
>Synopsis:       [patch] in_ifscrubprefix() - network route can be installed for interfaces marked down
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Aug 08 13:20:13 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Svatopluk Kraus
>Release:        current
>Organization:
>Environment:
>Description:
If interface goes down, then network route is deleted via in_ifscrubprefix() and can be replaced by same one on another interface. Interfaces marked down are not skipped during lookup.
>How-To-Repeat:

>Fix:
Index: sys/netinet/in.c
===================================================================
--- sys/netinet/in.c	(revision 224705)
+++ sys/netinet/in.c	(working copy)
@@ -1163,7 +1163,8 @@
 			p.s_addr &= ia->ia_sockmask.sin_addr.s_addr;
 		}
 
-		if (prefix.s_addr != p.s_addr)
+		if ((prefix.s_addr != p.s_addr) ||
+		    !(ia->ia_ifp->if_flags & IFF_UP))
 			continue;
 
 		/*


>Release-Note:
>Audit-Trail:
>Unformatted: