From owner-svn-src-head@FreeBSD.ORG Fri Jul 26 21:31:26 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 7FC6A84F for ; Fri, 26 Jul 2013 21:31:26 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com [209.85.215.43]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DF6E92171 for ; Fri, 26 Jul 2013 21:31:25 +0000 (UTC) Received: by mail-la0-f43.google.com with SMTP id fs13so2720487lab.16 for ; Fri, 26 Jul 2013 14:31:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=A6yNbZNavRW4QrQixNrGSVA7mUEmp96hrKg7WLbrN54=; b=jlGevIpMm0Nn8PvIb2nBRhnVIL2uF/q4mArkJ5aAqe+uUIXT2D9MkIT18e33y7/Omk L1lhUEPhVE/awhAZa2RFtMoi2RqzTRmpqGy3ORSnVJvwmc9PNsOGmVRS7yndou1p8sgC ebV5lDmfJK52H7JNa8uFHU7Eg6Fvu8sAUO/fukspDm20H0EPuLvufd0sUAQjFmyx4fTn EoGvryFUWdpmL6fZqFcJ0K1xoZWjFvkvmZ0sh2vJLQw84GAwEv8UwwgT/jML7U+IS+NG 6YPLXE07HhDzzyMqP/U3WwOUHrJL7lzrJt9SLLMSQSxGCfYpDwwKnYKH1Kf5anhX4E20 mDoA== X-Received: by 10.152.26.2 with SMTP id h2mr22339561lag.52.1374874277596; Fri, 26 Jul 2013 14:31:17 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.152.113.231 with HTTP; Fri, 26 Jul 2013 14:30:57 -0700 (PDT) In-Reply-To: <51F2E970.3070303@FreeBSD.org> References: <201307260200.r6Q207cB015223@svn.freebsd.org> <20130726150949.GC14175@stack.nl> <51F2E970.3070303@FreeBSD.org> From: Juli Mallett Date: Fri, 26 Jul 2013 14:30:57 -0700 X-Google-Sender-Auth: 8Ci1py3Dir307MjXbfdaGsMCEmY Message-ID: Subject: Re: svn commit: r253662 - in head: lib/libc/gen sys/vm tools/tools/sysdoc To: Andrey Zonov X-Gm-Message-State: ALoCoQlIvSi1PgytxBG2xk3NQTLkG3Coq7mTrfF61ZY7yL6rl/lobeHqNE3b+ADgZ+dllHMNTHNK Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jilles Tjoelker X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jul 2013 21:31:26 -0000 On Fri, Jul 26, 2013 at 2:26 PM, Andrey Zonov wrote: > On 7/26/13 8:09 AM, Jilles Tjoelker wrote: > > On Fri, Jul 26, 2013 at 02:00:07AM +0000, Andrey Zonov wrote: > >> Author: zont > >> Date: Fri Jul 26 02:00:06 2013 > >> New Revision: 253662 > >> URL: http://svnweb.freebsd.org/changeset/base/253662 > > > >> Log: > >> Remove define and documentation for vm_pageout_algorithm missed in > r253587 > > > >> Modified: > >> head/lib/libc/gen/sysctl.3 > >> head/sys/vm/vm_param.h > >> head/tools/tools/sysdoc/tunables.mdoc > > > >> Modified: head/sys/vm/vm_param.h > >> > ============================================================================== > >> --- head/sys/vm/vm_param.h Fri Jul 26 00:28:19 2013 (r253661) > >> +++ head/sys/vm/vm_param.h Fri Jul 26 02:00:06 2013 (r253662) > >> @@ -82,9 +82,8 @@ > >> #define VM_V_CACHE_MIN 7 /* cnt.v_cache_min */ > >> #define VM_V_CACHE_MAX 8 /* cnt.v_cache_max */ > >> #define VM_V_PAGEOUT_FREE_MIN 9 /* cnt.v_pageout_free_min > */ > >> -#define VM_PAGEOUT_ALGORITHM 10 /* pageout algorithm */ > >> -#define VM_SWAPPING_ENABLED 11 /* swapping enabled */ > >> -#define VM_MAXID 12 /* number of valid vm ids > */ > >> +#define VM_SWAPPING_ENABLED 10 /* swapping enabled */ > >> +#define VM_MAXID 11 /* number of valid vm ids > */ > > > > As noted in mail from Bruce Evans, please preserve the ABI of > > VM_SWAPPING_ENABLED here. > > > > I don't think it's a big problem. Internally we don't use it. Good > code uses sysctlbyname() instead of sysctl(). It doesn't seem to me > this is very popular sysctl. It's also CURRENT without MFC. That doesn't seem like a great argument. Why should we break the ABI for bad code that used that sysctl and all following? It seems pretty trivial to preserve, and no-cost. Also, the fact that it's in current misses the point completely: it breaks ABI with older binaries, namely older binaries running on -CURRENT. And not just for that field.