From owner-cvs-src@FreeBSD.ORG Fri Oct 26 23:26:52 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E201B16A41A; Fri, 26 Oct 2007 23:26:52 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id A323013C4A7; Fri, 26 Oct 2007 23:26:52 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (2sdeoxanlkyqg7ou@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l9QNQjA5042400; Fri, 26 Oct 2007 16:26:45 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l9QNQfAX042399; Fri, 26 Oct 2007 16:26:41 -0700 (PDT) (envelope-from jmg) Date: Fri, 26 Oct 2007 16:26:41 -0700 From: John-Mark Gurney To: Andrey Chernov , Rong-en Fan , Scott Long , John Baldwin , src-committers@freebsd.org, d@delphij.net, cvs-all@freebsd.org, Robert Watson , cvs-src@freebsd.org Message-ID: <20071026232641.GJ39759@funkthat.com> References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <20071025233536.B99770@fledge.watson.org> <472120E8.90504@samsco.org> <200710261144.34645.jhb@freebsd.org> <472217C2.8020800@samsco.org> <6eb82e0710260954m73b3f17bq2c72a4cdb597640e@mail.gmail.com> <20071026190039.GB38843@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071026190039.GB38843@nagual.pp.ru> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (hydrogen.funkthat.com [127.0.0.1]); Fri, 26 Oct 2007 16:26:45 -0700 (PDT) Cc: Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2007 23:26:53 -0000 Andrey Chernov wrote this message on Fri, Oct 26, 2007 at 23:00 +0400: > On Sat, Oct 27, 2007 at 12:54:21AM +0800, Rong-en Fan wrote: > > As for RELENG_7 and HEAD, I'm not 100% sure whether we should restore > > the compatibility as 1) 7.0 is not released yet, 2) we don't promise > > anything in > > HEAD branch. However, if most people think get rid of inline stuffs and > > have libc compatibility are nice, then we do the same for those two branches. > > Although standard permits functions only, I object against permanent > removing inlines from ctype. Almost every system have them as macros or > inlines and not as function calls, and it is for reason. Ctype functions > are very inside-loop-intensive, and not speeding them up may slowdown apps > which do intensive text processing. Have you done benchmarks to prove that making it a function will slow it down significantly? Things have changed over the years.... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."