From owner-freebsd-hackers  Wed Jan 31 16:01:54 1996
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id QAA26719
          for hackers-outgoing; Wed, 31 Jan 1996 16:01:54 -0800 (PST)
Received: from seagull.rtd.com (root@seagull.rtd.com [198.102.68.2])
          by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id QAA26712
          for <freebsd-hackers@freefall.FreeBSD.org>; Wed, 31 Jan 1996 16:01:51 -0800 (PST)
Received: (from dgy@localhost) by seagull.rtd.com (8.6.12/1.2) id RAA24829 for freebsd-hackers@freefall.cdrom.com; Wed, 31 Jan 1996 17:01:47 -0700
From: Don Yuniskis <dgy@rtd.com>
Message-Id: <199602010001.RAA24829@seagull.rtd.com>
Subject: 2.1R MAKEDEV patch?
To: freebsd-hackers@freefall.FreeBSD.org (FreeBSD hackers)
Date: Wed, 31 Jan 1996 17:01:46 +73700 (MST)
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-hackers@FreeBSD.ORG
Precedence: bulk

Greetings!
    If that which follows makes sense, could someone please commit it?
Briefly:
  - changes the st* devices (raw, norewind and eject) to allow members
    of the group to write them.  Otherwise, owner (root) would be required
    to perform dumps, etc.
  - changes the control devices for st* (i.e. st*ctl.*) to prevent anyone
    BUT the owner from accessing them.  This is now consistent with all
    other *ctl devices in the script.
  - explicitly chmod the lpctl and pcaudioctl devices to 600 (even though
    the script's umask causes them to be 600, anyway!)

Thx,
don
-------------------8<--------------8<----------------8<-----------------
*** MAKEDEV.orig	Wed Jan 31 16:42:28 1996
--- MAKEDEV	Wed Jan 31 16:46:59 1996
***************
*** 523,536 ****
  			mknod st${unit}ctl.${mode} c $chr `expr $unit '*' 16 + $mode '*' 4 + 3`
  			chgrp operator	rst${unit}.${mode}\
  					nrst${unit}.${mode} \
  					erst${unit}.${mode} \
  					st${unit}ctl.${mode}
! 			chmod 640	rst${unit}.${mode}\
  					nrst${unit}.${mode} \
  					erst${unit}.${mode}
! 			chmod 660	st${unit}ctl.${mode}
  		done
  		rm -f rst${unit}.ctl
  		mknod rst${unit}.ctl c $chr `expr $unit '*' 16 + $scsictl `
  		chmod 600 rst${unit}.ctl
  
--- 523,536 ----
  			mknod st${unit}ctl.${mode} c $chr `expr $unit '*' 16 + $mode '*' 4 + 3`
  			chgrp operator	rst${unit}.${mode}\
  					nrst${unit}.${mode} \
  					erst${unit}.${mode} \
  					st${unit}ctl.${mode}
! 			chmod 660	rst${unit}.${mode}\
  					nrst${unit}.${mode} \
  					erst${unit}.${mode}
! 			chmod 600	st${unit}ctl.${mode}
  		done
  		rm -f rst${unit}.ctl
  		mknod rst${unit}.ctl c $chr `expr $unit '*' 16 + $scsictl `
  		chmod 600 rst${unit}.ctl
  
***************
*** 654,663 ****
--- 654,664 ----
  	rm -f lpctl$unit
  	mknod lpt$unit c 16 $unit
  	mknod lpctl$unit c 16 `expr $unit + 128`
  	chown root.wheel lpt$unit
  	chown root.wheel lpctl$unit
+ 	chmod 600 lptctl$unit
  	;;
  
  tw*)
  	unit=`expr $i : 'tw\(.*\)'`
  	rm -f tw$unit
***************
*** 870,879 ****
--- 871,881 ----
  pcaudio)
  	rm -f pcaudio pcaudioctl
  	mknod pcaudio c 24 0
  	mknod pcaudioctl c 24 128
  	chown root.wheel pcaudio pcaudioctl
+ 	chmod 600 pcaudioctl
  	;;
  
  socksys)
  	rm -f socksys nfsd spx
  	mknod socksys c 41 0