From owner-svn-src-all@FreeBSD.ORG Thu Jan 6 09:02:19 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6422E1065672; Thu, 6 Jan 2011 09:02:19 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from out-0.mx.aerioconnect.net (outy.internet-mail-service.net [216.240.47.248]) by mx1.freebsd.org (Postfix) with ESMTP id 420E28FC08; Thu, 6 Jan 2011 09:02:19 +0000 (UTC) Received: from idiom.com (postfix@mx0.idiom.com [216.240.32.160]) by out-0.mx.aerioconnect.net (8.13.8/8.13.8) with ESMTP id p0692IAk001958; Thu, 6 Jan 2011 01:02:18 -0800 X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137]) by idiom.com (Postfix) with ESMTP id A710C2D6010; Thu, 6 Jan 2011 01:02:17 -0800 (PST) Message-ID: <4D258533.3@freebsd.org> Date: Thu, 06 Jan 2011 01:02:43 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Edward Tomasz Napierala References: <201101060833.p068Xmrj008299@svn.freebsd.org> In-Reply-To: <201101060833.p068Xmrj008299@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 216.240.47.51 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217048 - head/share/man/man9 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jan 2011 09:02:19 -0000 On 1/6/11 12:33 AM, Edward Tomasz Napierala wrote: > Author: trasz > Date: Thu Jan 6 08:33:48 2011 > New Revision: 217048 > URL: http://svn.freebsd.org/changeset/base/217048 > > Log: > Get rid of bad advice regarding /* NOTREACHED */. Compilers don't > really need it (one can use __dead2 instead), and style(9) was not > even consistent with itself in this regard. > > Modified: > head/share/man/man9/style.9 > > Modified: head/share/man/man9/style.9 > ============================================================================== > --- head/share/man/man9/style.9 Thu Jan 6 08:13:30 2011 (r217047) > +++ head/share/man/man9/style.9 Thu Jan 6 08:33:48 2011 (r217048) > @@ -470,9 +470,6 @@ statement that cascade should have a > .Li FALLTHROUGH > comment. > Numerical arguments should be checked for accuracy. > -Code that cannot be reached should have a > -.Li NOTREACHED > -comment. I object STRONGLY to this change. The NOTREACHED is also to help the reader understand what has happened and as an afterthought was also useful in LINT. I know know of no technological change to the average reader that makes it less useful. > .Bd -literal > while ((ch = getopt(argc, argv, "abNn:")) != -1) > switch (ch) { /* Indent the switch. */ > @@ -496,7 +493,6 @@ comment. > case '?': > default: > usage(); > - /* NOTREACHED */ > } > argc -= optind; > argv += optind; >