From owner-cvs-all  Tue Dec  4 17:45:55 2001
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5843237B417; Tue,  4 Dec 2001 17:45:47 -0800 (PST)
Received: (from luigi@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id fB51jlt89284;
	Tue, 4 Dec 2001 17:45:47 -0800 (PST)
	(envelope-from luigi)
Message-Id: <200112050145.fB51jlt89284@freefall.freebsd.org>
From: Luigi Rizzo <luigi@FreeBSD.org>
Date: Tue, 4 Dec 2001 17:45:47 -0800 (PST)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: cvs commit: src/sys/dev/fxp if_fxp.c src/sys/pci if_dc.c if_sis.c
X-FreeBSD-CVS-Branch: RELENG_4
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

luigi       2001/12/04 17:45:47 PST

  Modified files:        (Branch: RELENG_4)
    sys/dev/fxp          if_fxp.c 
    sys/pci              if_dc.c if_sis.c 
  Log:
  Make sure interrupts remain disabled once you reinitialize an interface
  on which you have enabled polling.
  
  This fixes the problem reported by a few people who enabled polling
  from /etc/sysctl.conf .
  
  Fixing the "fxp" driver was interesting: as a side effect of the
  initialization, the chip turns interrupts on, and I was misled in
  believing the opposite by the "Enable interrupts" comment in the code.
  So i decided to make the code explicitly turn interrupts off even
  in the "sis" driver which already had the correct code. You never know.
  
  Note-to-self: never make assumptions on how things should work.
  
  Note-to-others: did I test this case ? Yes, on a "sis" and "dc" board,
  (the code for the latter was unintentionally lost during the final
  code cleanup). I forgot to reproduce the actual problem on the "fxp",
  because the interface was already initialized when i turned polling on.
  
  Revision    Changes    Path
  1.110.2.12  +9 -0      src/sys/dev/fxp/if_fxp.c
  1.9.2.27    +10 -0     src/sys/pci/if_dc.c
  1.13.4.12   +7 -1      src/sys/pci/if_sis.c

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message