From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 18 23:50:23 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80932106566B for ; Mon, 18 Jun 2012 23:50:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 559B08FC14 for ; Mon, 18 Jun 2012 23:50:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5INoNGK036098 for ; Mon, 18 Jun 2012 23:50:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5INoNwc036096; Mon, 18 Jun 2012 23:50:23 GMT (envelope-from gnats) Resent-Date: Mon, 18 Jun 2012 23:50:23 GMT Resent-Message-Id: <201206182350.q5INoNwc036096@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jason Helfman Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58E011065670; Mon, 18 Jun 2012 23:47:06 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id 387968FC08; Mon, 18 Jun 2012 23:47:06 +0000 (UTC) Received: from mail.dw.redsrci.com (localhost [127.0.0.1]) by mail.dw.redsrci.com (Postfix) with ESMTP id 322B86FDA59; Mon, 18 Jun 2012 16:47:06 -0700 (PDT) Received: from mail.dw.redsrci.com ([127.0.0.1]) by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3pXWyLE7djmw; Mon, 18 Jun 2012 16:47:06 -0700 (PDT) Received: from experts-exchange.com (unknown [192.168.103.120]) by mail.dw.redsrci.com (Postfix) with SMTP id 0DB036FDA57; Mon, 18 Jun 2012 16:47:06 -0700 (PDT) Received: (nullmailer pid 28119 invoked by uid 1001); Mon, 18 Jun 2012 23:45:32 -0000 Message-Id: <1340063132.067781.28118.nullmailer@experts-exchange.com> Date: Mon, 18 Jun 2012 16:45:32 -0700 From: Jason Helfman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: vbox@FreeBSD.org Subject: ports/169224: [PATCH] emulators/virtualbox-ose-legacy: fix usage of ${SRC_BASE} before it is defined X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 23:50:23 -0000 >Number: 169224 >Category: ports >Synopsis: [PATCH] emulators/virtualbox-ose-legacy: fix usage of ${SRC_BASE} before it is defined >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jun 18 23:50:22 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Jason Helfman >Release: FreeBSD 8.3-RELEASE amd64 >Organization: >Environment: System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr 9 21:23:18 UTC >Description: Original PR filed as ports/165994 SRC_BASE is being used before being defined in several ports. it happened to work anyways in most cases because the main use of SRC_BASE is for checking if ${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/. pet portlint on license placement Port maintainer (vbox@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS) >How-To-Repeat: >Fix: --- virtualbox-ose-legacy-4.0.16_2.patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/emulators/virtualbox-ose-legacy/Makefile,v retrieving revision 1.47 diff -u -r1.47 Makefile --- Makefile 6 Jun 2012 06:43:44 -0000 1.47 +++ Makefile 18 Jun 2012 23:46:34 -0000 @@ -21,6 +21,9 @@ MAINTAINER= vbox@FreeBSD.org COMMENT= A general-purpose full virtualizer for x86 hardware +LICENSE= GPLv2 +LICENSE_FILE= ${WRKSRC}/COPYING + BUILD_DEPENDS= yasm:${PORTSDIR}/devel/yasm \ as86:${PORTSDIR}/devel/dev86 \ xsltproc:${PORTSDIR}/textproc/libxslt \ @@ -30,9 +33,6 @@ curl.6:${PORTSDIR}/ftp/curl RUN_DEPENDS= /boot/modules/vboxdrv.ko:${PORTSDIR}/emulators/virtualbox-ose-kmod-legacy -LICENSE= GPLv2 -LICENSE_FILE= ${WRKSRC}/COPYING - WRKSRC= ${WRKDIR}/VirtualBox-${PORTVERSION}_OSE ONLY_FOR_ARCHS= i386 amd64 USE_CDRTOOLS= yes @@ -80,10 +80,6 @@ SUB_LIST+= VBOXUSER=${VBOXUSER} USE_RC_SUBR+= vboxheadless -KMK_BUILDTYPE= release -KMK_CONFIG= VBOX_LIBPATH_X11=${LOCALBASE} VBOX_FREEBSD_SRC=${SRC_BASE}/sys -KMK_FLAGS= - .if defined(WITHOUT_QT4) && !defined(WITHOUT_NLS) BROKEN= NLS support requires QT4 frontend. Run 'make config' again! .endif @@ -124,6 +120,12 @@ PLIST_SUB+= GUESTADDITIONS="@comment " .endif +.include + +KMK_BUILDTYPE= release +KMK_CONFIG= VBOX_LIBPATH_X11=${LOCALBASE} VBOX_FREEBSD_SRC=${SRC_BASE}/sys +KMK_FLAGS= + .if defined(WITH_DEBUG) KMK_FLAGS+= BUILD_TYPE=debug KMK_BUILDTYPE= debug @@ -174,8 +176,6 @@ PLIST_SUB+= I386="@comment " .endif -.include - .if ${OSVERSION} > 900012 EXTRA_PATCHES+= ${FILESDIR}/extrapatch-include-iprt-string.h .endif --- virtualbox-ose-legacy-4.0.16_2.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: