From owner-cvs-all@FreeBSD.ORG Sun Sep 11 06:01:46 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C125416A41F; Sun, 11 Sep 2005 06:01:46 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A81C43D45; Sun, 11 Sep 2005 06:01:46 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j8B61cEd083793; Sat, 10 Sep 2005 23:01:39 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j8B61cL8083792; Sat, 10 Sep 2005 23:01:38 -0700 (PDT) (envelope-from obrien) Date: Sat, 10 Sep 2005 23:01:38 -0700 From: "David O'Brien" To: Sam Leffler Message-ID: <20050911060138.GA83586@dragon.NUXI.org> References: <200509110338.j8B3cJwv098050@repoman.freebsd.org> <4323BB54.6060600@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4323BB54.6060600@errno.com> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 06:01:46 -0000 On Sat, Sep 10, 2005 at 10:06:28PM -0700, Sam Leffler wrote: > David E. O'Brien wrote: > >obrien 2005-09-11 03:38:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files kern.pre.mk > > Log: > > Don't pollute the entire kernel build with -I$S/contrib/dev/ath and > > -I$S/contrib/dev/ath/freebsd. "ATH_BUILDING_FROM_SOURCE" can be defined > > to > > globally get back -I$S/contrib/dev/ath. > > Thanks for explicitly ignoring my request for you NOT to do this. It's > really great how you do these drive-by commits that do nothing but f*ck > up people's development environment. > Sam I did my best to take your needs into account. I even asked you to propose a patch when you didn't like the ones I sent you - your response was "David, I have no time to waste on stuff like this." "-INCLUDES+= -I$S/contrib/dev/ath" should never have been in the public FreeBSD source tree as not a single file in /usr/src/sys needed it to compile. We don't commit Yahoo!'s, The Weather Channel, Interjet's or any other vendor-specific needs into the open source /usr/src. I think you're more than able to stick "ATH_BUILDING_FROM_SOURCE=yes" in the /etc/make.conf of the machines you build the ath(4) HAL on. I'm sorry you don't see that we shouldn't pollute the kernel build with tons of -I's. It was getting out of hand that every one felt they could add yet another global -I with every new code import rather than edit their code to build in our tree correctly. -- -- David (obrien@FreeBSD.org)