From owner-svn-src-all@FreeBSD.ORG Tue Jul 19 00:59:36 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD93B1065670; Tue, 19 Jul 2011 00:59:36 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-yi0-f54.google.com (mail-yi0-f54.google.com [209.85.218.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7296E8FC1B; Tue, 19 Jul 2011 00:59:36 +0000 (UTC) Received: by yic13 with SMTP id 13so1927750yic.13 for ; Mon, 18 Jul 2011 17:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=dddK0h8zB7+rURb1vFVZxNkizeTGMbLruxFm1m1rI7Y=; b=Lmiib2j4XhXnsJ0NptiRSTd1CupjFNF6UEPnuQJ4kbTiRru9FadlKv/XYRFyPs2bZq cr+P3dfC+1Ovl51UFtRmBFgBdVsOndtHKaws2QIOie3wg3K0S3YAix9AUU4qqIKXrfmg B/bHjb+w1FcOoq0EV4jccHpFKCXcgd75gsons= MIME-Version: 1.0 Received: by 10.236.147.111 with SMTP id s75mr69324yhj.272.1311037174751; Mon, 18 Jul 2011 17:59:34 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.105.169 with HTTP; Mon, 18 Jul 2011 17:59:34 -0700 (PDT) In-Reply-To: <208D139E-CDC3-428D-8D5F-F772BFAF164C@xcllnt.net> References: <201107181519.p6IFJfOK028280@svn.freebsd.org> <208D139E-CDC3-428D-8D5F-F772BFAF164C@xcllnt.net> Date: Tue, 19 Jul 2011 02:59:34 +0200 X-Google-Sender-Auth: jC3gBHHMpGslCRxhMF-mt_3X3f8 Message-ID: From: Attilio Rao To: Marcel Moolenaar Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r224187 - in head: sys/amd64/amd64 sys/arm/arm sys/arm/sa11x0 sys/i386/i386 sys/ia64/ia64 sys/kern sys/mips/mips sys/powerpc/aim sys/powerpc/booke sys/sparc64/sparc64 sys/sys usr.bin/vm... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2011 00:59:37 -0000 2011/7/19 Marcel Moolenaar : > > On Jul 18, 2011, at 8:19 AM, Attilio Rao wrote: > >> Author: attilio >> Date: Mon Jul 18 15:19:40 2011 >> New Revision: 224187 >> URL: http://svn.freebsd.org/changeset/base/224187 >> >> Log: >> =C2=A0- Remove the eintrcnt/eintrnames usage and introduce the concept o= f >> =C2=A0 =C2=A0sintrcnt/sintrnames which are symbols containing the size o= f the 2 >> =C2=A0 =C2=A0tables. >> =C2=A0- For amd64/i386 remove the storage of intr* stuff from assembly f= iles. >> =C2=A0 =C2=A0This area can be widely improved by applying the same to ot= her >> =C2=A0 =C2=A0architectures and likely finding an unified approach among = them and >> =C2=A0 =C2=A0move the whole code to be MI. More work in this area is exp= ected to >> =C2=A0 =C2=A0happen fairly soon. >> >> =C2=A0No MFC is previewed for this patch. > > You just broke ia64 and possibly other 64-bit architectures: > > ".word" declares a 16-bit integral on ia64 and the size symbols > are of type size_t (=3D64 bit). We'll be having misaligned loads > (=3D kernel panics) and/or reading garbage... I'm a bit surprised of this though. .hword was supposed to be the 16-bit integral, while .word was supposed to be the 32-bits one, if I read my "info as" on amd64. Anyway, what do you think about this patch? (I still need to test it): http://www.freebsd.org/~attilio/64bits-fixup.diff Thanks, Attilio --=20 Peace can only be achieved by understanding - A. Einstein